On 2021/08/17 11:00, Landry Breuil wrote:
> Le Tue, Aug 17, 2021 at 09:26:19AM +0100, Stuart Henderson a écrit :
> > On 2021/08/17 09:58, Landry Breuil wrote:
> > > hi,
> > > 
> > > here's an update to pgbouncer 1.16, see
> > > http://www.pgbouncer.org/changelog.html#pgbouncer-116x
> > > http://www.pgbouncer.org/changelog.html#pgbouncer-115x
> > > for changes since the 1.14 we're shipping.
> > > 
> > > testing welcome, builds for me !
> > 
> > Not new, but I don't like these,
> > 
> > In file included from lib/usual/tls/tls_util.c:19:
> > lib/usual/tls/tls_compat.h:33:9: warning: 'NID_kx_ecdhe' macro redefined 
> > [-Wmacro-redefined]
> > #define NID_kx_ecdhe (-90)
> >         ^
> > /usr/include/openssl/obj_mac.h:4419:9: note: previous definition is here
> > #define NID_kx_ecdhe            960
> >         ^
> > In file included from lib/usual/tls/tls_util.c:19:
> > lib/usual/tls/tls_compat.h:34:9: warning: 'NID_kx_dhe' macro redefined 
> > [-Wmacro-redefined]
> > #define NID_kx_dhe (-91)
> >         ^
> > /usr/include/openssl/obj_mac.h:4423:9: note: previous definition is here
> > #define NID_kx_dhe              961
> >         ^
> > 
> > ...how about the updated diff below?
> 
> yeah i saw them and didnt bother, your diff looks fine for that.

I guess it's actually a noop at the moment, grep found them but I
didn't look at surrounding lines before - they're hidden behind
#ifdef SSL_get_shared_curve - makes sense to fix anyway I think.

> > > --#include <pthread.h>
> > > -+#include <pthread.h>
> > 
> > they what?! :)
> 
> yeah i have no idea how that one happened.... configure.ac git log shows
> nothing ?
> 
> > +- Several levels of brutality when rotating connections
> 
> LOL!
> 

Reply via email to