On 2021-08-23 18:37 +02, Paco Esteban <[email protected]> wrote: > On Mon, 23 Aug 2021, Florian Obser wrote: > >> Hi, >> >> the new version of ephemetoot allows archiving of media_attachments next >> to the toots (which is kinda my fault). >> >> OK? > > Hi Florian. Your diff is ok, but tests fail now for the port. This is > because upstream tries to retrieve a JPG from the internet during the > test of your new functionality, and we (at least I) use PORTS_PRIVSEP > and _pbuild is not allowed to access the internet. >
Sorry about that, I was not paying attention *how* they implemented that test. I had asked for help with the test because I couldn't figure out how that monkeypatching works. > I've created a PR to fix this upstream: > https://github.com/hughrun/ephemetoot/pull/76 > > With that all tests pass again. I think I'll wait a bit to see what > upstream says about my PR (which probably will need some tweaking). > If they don't respond, we I can include it as a patch. > Working with the maintainer on my PR was pleasent, they just took a few days to respond. -- I'm not entirely sure you are real.
