On 2021/09/14 08:21, Stefan Hagen wrote:
> Hi,
>
> This is a small fix for the luakit port, it leads to the correct
> `luakit --version` output and also prevents a shell script from running
> for each C file.
>
> I saw that build-utils/getversion.sh I called for every file when I had
> an error in there and the error showed up after each file.
>
> Setting VERSION directly prevents it from running getversion.sh.
>
> OK?
>
> Best regards,
> Stefan
>
> Index: www/luakit/Makefile
> ===================================================================
> RCS file: /cvs/ports/www/luakit/Makefile,v
> retrieving revision 1.31
> diff -u -p -u -p -r1.31 Makefile
> --- www/luakit/Makefile 1 Sep 2021 08:20:22 -0000 1.31
> +++ www/luakit/Makefile 13 Sep 2021 16:47:36 -0000
> @@ -5,7 +5,7 @@ COMMENT = fast, small, webkit based brow
> GH_ACCOUNT = luakit
> GH_PROJECT = luakit
> GH_TAGNAME = 2.3
> -REVISION = 1
> +REVISION = 2
>
> EPOCH = 1
>
> @@ -56,6 +56,7 @@ MAKE_FLAGS += LUA_BIN_NAME=${MODLUA_BIN}
> PIXMAPDIR=${PREFIX}/share/pixmaps/ \
> APPDIR=${PREFIX}/share/applications/ \
> PREFIX=${PREFIX} \
> - DEVELOPMENT_PATHS=0
> + DEVELOPMENT_PATHS=0 \
> + VERSION=${GH_TAGNAME}
>
> .include <bsd.port.mk>
>
Committed with a small tweak, to add a comment near GH_TAGNAME to
mention that it's used later in the Makefile. Experience has shown that
this is easy to miss this if a later update a port later (for example
if it moves to proper release tarballs).
