On Mon, Sep 13, 2021 at 02:22:38PM +0100, Stuart Henderson wrote:
> On 2021/09/12 23:45, Kinichiro Inoguchi wrote:
> > - Added "REVISION-main=0".
> > I didn't add REVISION-main with my last diff since I thought
> > 'libmarisa-main'
> > would be the first revision but it was wrong.
>
> That would be correct if the PKGNAME changed, but it doesn't, it is still
> "libmarisa-$VERSION".
>
> > +PKGNAME-python = libmarisa-python-${V}
>
> Please set this to py3-libmarisa-${V}
>
> > +.if ${BUILD_PACKAGES:M-python}
> > +BUILD_DEPENDS = devel/swig
>
> and please use BUILD_DEPENDS +=, not just =. Just defense against adding
> a BUILD_DEPENDS for the non-Python version later.
>
> OK sthen@ with those two changes.
I've committed with your two inputs, thanks for your comments and advise.
And, SASANO-san, thanks for your understanding, and go ahead your libskk!
