On Fri, Oct 15, 2021 at 12:58:32PM +0000, Brian Callahan wrote:
> Hello Pat --
>
> On 10/15/2021 12:19 AM, Pat Jensen wrote:
> > All,
> >
> > I'm submitting a unified diff of a new port of my console word search
> > game for OpenBSD.
> >
> > Please evaluate and comment on any necessary changes.
> >
>
> New ports are usually sent as tarballs. Attached is an improved version of
> your port.
>
> Changes:
> * Lowercase first letter of COMMENT as is style
> * You use 2.0 in both DISTNAME and MASTER_SITES so 2.0 becomes its own
> variable, V.
> * Tightened up whitespace
> * Leaf ports are going to be python 3 by default no need to specify FLAVOR
> * One of your do-install lines was over 80 characters. I was able to shorten
> it, but otherwise you'd have to split it over multiple lines
> * You want ${INSTALL_DATA_DIR}, not mkdir -p, in your do-install routine
Oh, thanks for this reminder on something I forgot to fix! Runs to fix
another port.
> * PLIST changed when I ran `make update-plist`
>
> Works for me on amd64.
>
> ~Brian
Works great. Ok to import. Hard to read on 4k! :D
--
Tracey Emery
