On 2021/10/16 20:33, Kevin Lo wrote: > On Fri, Oct 15, 2021 at 11:35:33AM +0100, Stuart Henderson wrote: > > > > On 2021/10/15 13:57, Kevin Lo wrote: > > > Hi, > > > > > > Attached is a port of arm-compute-library 21.08. > > > > > > Comment: > > > Arm compute library > > > > > > Description: > > > Arm Compute Library is a software library for computer vision and machine > > > learning. It is a collection of low-level functions optimized for Arm CPU > > > and GPU architectures targeted at image processing, computer vision, and > > > machine learning. > > > > > > Tested on arm64(RockPro64). > > > OK? > > > > scons.port.mk should be passing in CC/CXX anyway so the patches to > > default_c_compiler/default_cpp_compiler _ought_ not to be necessary > > (and if they are, it's indicating that something isn't working > > correctly with scons.port.mk) > > Thanks for the comments. I removed a patch about default_c_compiler / > default_cpp_compiler, here's the revised tarball, thanks.
OK sthen@. I do think MAKE_ENV should not be necessary, but I think there is something wrong with scons.port.mk so I am ok with this as a workaround. One thing I looked at when reviewing - often software uses "native build" to mean "use CPU features detected from the build machine" (-march=native compiler flag) so I wanted to check that it wasn't the case here - aarch64 builds are done on eMAG boxes, cpu "Applied Micro X-Gene r3p2" so I wanted to make sure it doesn't use some fancy feature which isn't available on other machines. So it might be worth a little comment e.g. # "build=native" here just means "not cross-compiled"
