On Fri 22/10/2021 22:04, Martin Reindl wrote:
> On Fri, Oct 22, 2021 at 04:09:07PM +0200, Bjorn Ketelaars wrote:
> > On Fri 22/10/2021 13:23, Bjorn Ketelaars wrote:
> > > On Fri 22/10/2021 09:55, Martin Reindl wrote:
> > > > Am 22.10.2021 um 09:49 schrieb Stuart Henderson:
> > > > > Only issue in the i386 build was math/py-h5py which specifically
> > > > > wants 1.16.5.
> > > > >
> > > >
> > > > Yes, this is one patch which can go away with newer numpy.
> > >
> > > That is not entirely true. When building, py-h5py checks for a specific
> > > version of py-numpy. Diff below fixes this by checking for a minimum
> > > version similar to RUN_REQUIRES in setup.py.
> > >
> > > BTW 'make test' fails because of a py-numpy related issue. This happens
> > > with both py-numpy-1.16.5 and py-numpy-1.19.5. Have you seen this
> > > before? Both test logs attached.
> >
> > Correction, failing tests is not because of numpy. It seems it is
> > because of py-h5py:
> >
> > Found a core file in py-h5py's $WRKDIR. Interesting bits:
>
> This one should fly with both old numpy (tested on amd64) and new numpy
> (tested on arm64).
Diff looks good, and builds with py-numpy-1.19.5. This newer version of
py-h5py adds another test that requires the mpi_file_name fixture. With
the diff below on top of your diff all tests pass.
Please commit. OK bket@
diff --git patches/patch-h5py_tests_test_file_py
patches/patch-h5py_tests_test_file_py
index d4db14d84aa..28bf37d7983 100644
--- patches/patch-h5py_tests_test_file_py
+++ patches/patch-h5py_tests_test_file_py
@@ -11,7 +11,15 @@ Index: h5py/tests/test_file.py
def test_mpio(self, mpi_file_name):
""" MPIO driver and options """
from mpi4py import MPI
-@@ -841,6 +842,7 @@ class TestMPI(object):
+@@ -833,6 +834,7 @@ class TestMPI(object):
+ assert f
+ assert f.driver == 'mpio'
+
++ @pytest.mark.skip(reason="fixture 'mpi_file_name' not present")
+ def test_mpio_append(self, mpi_file_name):
+ """ Testing creation of file with append """
+ from mpi4py import MPI
+@@ -841,6 +843,7 @@ class TestMPI(object):
assert f
assert f.driver == 'mpio'
@@ -19,7 +27,7 @@ Index: h5py/tests/test_file.py
@pytest.mark.skipif(h5py.version.hdf5_version_tuple < (1, 8, 9),
reason="mpio atomic file operations were added in
HDF5 1.8.9+")
def test_mpi_atomic(self, mpi_file_name):
-@@ -852,6 +854,7 @@ class TestMPI(object):
+@@ -852,6 +855,7 @@ class TestMPI(object):
f.atomic = True
assert f.atomic
