Stephen Gregoratto <[email protected]> writes: > Hi Stu, > > Thanks for your feedback. Attached is a tarball with the changes you > requested. In v1, I actually installed an rc script that the author > wrote in the project's contrib directory. Now, I've put a copy of it > under pkg/gmid.rc. I believe this is OK to import? > > Also attached inline is a patch that adds _gmid to the user list, in > case you need that.
Hello, Thank you for working on a port for gmid :D I can confirm it works on OpenBSD (disclaimer: I'm the author ;-) and the port looks fine. There are two nits: ALL_TARGET/INSTALL_TARGET in the makefile are redundant and portcheck complains about: % portcheck hardcoded paths detected in pkg/gmid.rc, consider using SUBST_VARS and TRUEPREFIX/LOCALBASE/LOCALSTATEDIR/VARBASE pkg/gmid.rc does not have $OpenBSD$ RCS tag at the top otherwise, make port-lib-depends-check looks fine and the plist is correct too. (attaching an updated tarball.) Also, since the rc script needs /etc/gmid.conf it may be a good idea to install a sample file? (e.g. in the freebsd port I'm installing this sample config[0].) For me the port is fine as-is thought, as the manpage already includes some examples. Thanks! Omar Polo [0]: https://cgit.freebsd.org/ports/tree/net/gmid/files/gmid.conf.sample
gmid.tar.gz
Description: Binary data
