On Sat, 30 Oct 2021, Stuart Henderson wrote:
> On 2021/10/30 13:52, Paco Esteban wrote:
> > Hi ports@,
> >
> > I just found out that productivity/vdirsyncer was not working because
> > one of its dependencies (devel/py-click-threading) was broken.
>
> I'm OK with the update, but any more info on the breakage? It's working
> for me on a 7.0 box and I don't think anything relevant changed since then.
This is the error I got before upgrading devel/py-click-threading:
$ vdirsyncer -vdebug sync
debug: Using 1 maximal workers.
error: Unknown error occurred: Function has keyword-only parameters or
annotations, use inspect.signature() API which can support them
error: Use `-vdebug` to see the full traceback.
debug: File
"/usr/local/lib/python3.8/site-packages/vdirsyncer/cli/__init__.py", line 30,
in inner
debug: f(*a, **kw)
debug: File
"/usr/local/lib/python3.8/site-packages/vdirsyncer/cli/__init__.py", line 157,
in sync
debug: with wq.join():
debug: File "/usr/local/lib/python3.8/contextlib.py", line 113, in __enter__
debug: return next(self.gen)
debug: File "/usr/local/lib/python3.8/site-packages/vdirsyncer/cli/utils.py",
line 373, in join
debug: with ui_worker.patch_click():
debug: File "/usr/local/lib/python3.8/contextlib.py", line 113, in __enter__
debug: return next(self.gen)
debug: File
"/usr/local/lib/python3.8/site-packages/click_threading/__init__.py", line 144,
in patch_click
debug: with patch_ui_functions(wrapper):
debug: File "/usr/local/lib/python3.8/contextlib.py", line 113, in __enter__
debug: return next(self.gen)
debug: File
"/usr/local/lib/python3.8/site-packages/click_threading/monkey.py", line 43, in
patch_ui_functions
debug: argspec = inspect.getargspec(f)
debug: File "/usr/local/lib/python3.8/inspect.py", line 1095, in getargspec
debug: raise ValueError("Function has keyword-only parameters or
annotations"
I think the commit that fixes this is:
https://github.com/click-contrib/click-threading/commit/2034afdf0dbfbf938ae28ede2a816ad3d137cbec
I have not tried this on 7.0, so not sure why you don't see it.
>
> > Here's a patch that updates deve/py-click-threading to its latest
> > version (0.5.0), which fixes the bug and another one that updates
> > productivity/vdirsyncer to 0.18.0. It seems that 0.19.0 exists for the
> > latter, but is not on pypi, only on their github repo.
>
> ok for 0.18.0
>
> 0.19.0 looks like a useful update too but we'll need aiohttp-oauthlib first
>
--
Paco Esteban.
0x5818130B8A6DBC03
