Rafael Sadowski wrote:
> On Tue Nov 16, 2021 at 06:38:29AM +0000, Adnan Shameem wrote:
> > I couldn't find any screen color picker on ports, which is essential
> > for graphic and web designers.
> >
> > So I made a port for ColorGrab, a color picker that can pick any
> > color from screen without opening any files, taking screenshots or
> > using any developer tools; allows to optionally tweak the color and
> > provides output for use in graphic, web and print design. Its UI is
> > simple, but packed with lots of features.
> >
> > Announcement blog with screenshot and basic info:
> > https://nielssp.dk/2015/02/colorgrab-a-crossplatform-color-picker/
> >
> > One thing though. I tried to get rid of the "do-install" target, but
> > couldn't. Please let me know if there is a way.
> >
> > Please also let me know if there are any other changes that could be
> > made.
> >
> > Regards,
> > Adnan
>
> Not really an color picker for graphic and web designers but very
> helpful for web designers: KDE kontrast:
>
> - https://apps.kde.org/kontrast/
> - https://marc.info/?l=openbsd-ports&m=163678480815937&w=2 (This tarball is
> missing devel/kf5/kdeclarative as build dep)
I don't know what "for graphic and web designers" means. There's also
x11/xcolor and x11/gcolor2 (which is essentially the same as colorgrab).
There's also my own (xpick, which is on the list somewhere).
PATCH_LIST is not necessary.
The do-install target can be simplified by reducing repetitions with
a for loop.
for s in 16x16 32x32 48x48 64x64 128x128 256x256; \
do \
${INSTALL_DATA_DIR} ${PREFIX}/share/icons/hicolor/$$s/apps; \
${INSTALL_DATA} ${WRKSRC}/img/$$s.png \
${PREFIX}/share/icons/hicolor/$$s/apps/colorgrab.png; \
done
portcheck complains about RDEP. This is for RUN_DEPENDS, the suggestions
should be added.
missing RDEP on x11/gtk+3,-guic
missing RDEP on devel/desktop-file-utils
Try to align the sequence in your Makefile to
ports/infrastructure/templates/Makefile.template.
The tab indent level within a block should be the same.
Best Regards,
Stefan
