Hi Omar,

hope you're doing well.

On Thu, Nov 18, 2021 at 06:34:08PM +0100, Omar Polo wrote:
> "Sergey A. Osokin" <o...@freebsd.org> writes:
> 
> > here's the maintainer update for www/unit port, could
> > you please review and commit.
> 
> I think the REVISION-python should be dropped since we're bumping the
> version.  `make port-lib-depends-check` still complains about extra
> WANTLIB for -ruby :/
> 
> Regarding the tests there seem to be slightly more failures.
> 
> With the current version:
> > 69 failed, 366 passed, 265 skipped, 144 error in 362.32 seconds
> and after the update:
> > 79 failed, 316 passed, 274 skipped, 273 error in 345.81 seconds

The NGINX Unit test suite is based on the recent version of pytest
framework, so we'd need to update devel/py-test first.

> but I don't run this so I don't know the real impact of these numbers;
> I've tested only for curiosity and because I spotted the REVISION-python
> in the context of the diff ;)

[...]

> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/www/unit/Makefile,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile
> --- Makefile  2 Nov 2021 00:02:57 -0000       1.3
> +++ Makefile  18 Nov 2021 17:33:55 -0000
> @@ -5,9 +5,8 @@ COMMENT-perl= NGINX Unit perl module
>  COMMENT-python=      NGINX Unit python module
>  COMMENT-ruby=        NGINX Unit ruby module
>  
> -VERSION=     1.25.0
> +VERSION=     1.26.0
>  DISTNAME=    unit-${VERSION}
> -REVISION-python= 0
>  
>  PKGNAME-main=        ${DISTNAME}
>  PKGNAME-perl=        unit-perl-${VERSION}
> Index: distinfo
> ===================================================================
> RCS file: /home/cvs/ports/www/unit/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo  23 Oct 2021 16:02:51 -0000      1.1.1.1
> +++ distinfo  18 Nov 2021 17:33:59 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (unit-1.25.0.tar.gz) = SrTwWpNN0AYowOBn99DFumK7Veni56Mz+jdkoYC5dl0=
> -SIZE (unit-1.25.0.tar.gz) = 853280
> +SHA256 (unit-1.26.0.tar.gz) = wEpAq4LsDVWFqZl6SEMX2J6VBECJ1y68yu3Shg3r9vw=
> +SIZE (unit-1.26.0.tar.gz) = 865556

Brilliant!

-- 
Sergey Osokin
> 

Attachment: signature.asc
Description: PGP signature

Reply via email to