Kinichiro Inoguchi <[email protected]> writes: > I had built and tested this on amd64, and saw worked successfully. > Also both 'make plist' and 'make port-lib-depends-check' were fine. > It is good to have another review, but I am ok with this. > ok inoguchi@
I can't really test it, but glancing at the makefile > COMPILER = base-clang ports-gcc base-gcc caught my eye. The CMakeLists.txt doesn't set an explicit C version, but glancing at the code it seems C99 mostly so that line can be dropped. Otherwise, I think `COMPILER_LANG = c' should also be set and a comment needed to explain why (for instance if it actually needs C11 or newer.) But if that's the case, the COMPILER line should be already wrong if my understanding of COMPILER/COMPILER_LANGS is correct. Oh, another small nitpick, the license is GPLv3+ because of the "either version 3 of the License, or (at your option) any later version" phrase in the source files. (I've explicitly checked for this since I've got it wrong twice recently :-) Anyway, it builds fine, WANTLIB and the plist are fine and portcheck is happy. I don't know how meaningful is an OK from me since I can't really test it at runtime, but the port looks fine! Attaching a tarball without COMPILER and the fixed license marker.
fcitx-kkc.tar.gz
Description: Binary data
