Adriano Barbosa <[email protected]> writes:
> Hi. > Thank you very much for your review and help, Aaron. Wish I knew about > that man page earlier today haha > The new tarball is attached. Glad to help! One thing I forgot to mention, the MODGO_VERSION line should be removed from modules.inc - otherwise ya might update the Makefile and wonder why things aren't working :D With that line removed this is OK abieber@ to import! > > Obrigado. > > Em qua., 1 de dez. de 2021 às 11:47, Aaron Bieber > <[email protected]> escreveu: >> >> >> Adriano Barbosa <[email protected]> writes: >> >> > Hi. >> > This is the port for vultr-cli, a command line tool for Vultr cloud >> > provider services. >> > https://www.vultr.com >> > https://github.com/vultr/vultr-cli >> > >> > It's my first time using go-lang and any help is appreciated. I'm not >> > sure if running `go mod vendor` in post-extract is the right way of >> > doing it, for example. >> > >> > Obrigado. >> >> Hi! >> >> Couple things: >> >> - Ports are not allowed to download things outside of the distfiles. So >> running `go mod vendor` in the Makefile is a nono. >> - Your DISTNAME has "vult-cli" - I assume that should be "vultr-cli"? >> >> Despite having a "vendor" directory, the modules aren't actually >> vendored (thus your need to run 'go mod vendor'). This means we need to >> generate the modules list. >> >> You can generate a list of modules by setting MODGO_MODNAME and >> MODGO_VERSION (as you have) and running "make modgo-gen-modules". >> Typically the output of this list is kept in "modules.inc" and then >> included in the Makefile via a '.include "modules.inc"' line. >> >> Once you have the list you can re-gen the distinfo file with "make >> makesum". >> >> Since they have the vendor directory - we will need to explicitly remove >> it during "do-build", something like: >> >> do-build: >> cd ${WRKSRC} && \ >> rm -rf vendor && \ >> ${MODGO_BUILD_CMD} >> >> More info on the MODGO stuff can be found here: >> https://man.openbsd.org/go-module >> >> Let me know if you want/need more pointers! >> >> Cheers, >> Aaron
