On 2021/12/09 00:58, Klemens Nanni wrote: > On Tue, Dec 07, 2021 at 10:44:27PM +0000, Stuart Henderson wrote: > > On 2021/12/07 21:28, Klemens Nanni wrote: > > > https://github.com/peha/ > > > > odd, no project name > > Ha, peha uses MASTER_SITES=https://github.com/peha/ and different > authors/projects in DISTFILES. > > > > https://github.com/gonzalo-/openbsd-distfiles > > > > I don't think this is a good HOMEPAGE for the port > > Well, that *is* the home page, isn't it? Not much to see there but > better than no HOMEPAGE in pkg_info(1) output having to grab the ports > Makefile for MASTER_SITES or search the web for the port, imho.
No, it's just where gonzalo@ mirrored the distfile, that would be like setting a homepage to distfiles.bsdfrog.org. In thus case it would be https://github.com/jimrazmus/greyscanner (which probably didn't exist when the port was last touched). I very rarely (almost never) look in pkg_info for details of an individual package, if I'm interested in some software in ports I'll look in the ports tree instead. So for me, an automatic setting is much less useful than an explicit HOMEPAGE setting that can be copied/pasted direct from the Makefile (otherwise I need make show=HOMEPAGE, or figure out the package name so I can use pkg_info). > Do people run portcheck(1) regularly? I must admit I don't, luckily > portimport(1) keeps reminding me of its existence. I can't speak for others, I do usually run it for new ports, and sometimes run it for updates if there were big changes. > If bsd.port.mk is deemed OK for this, I've also added a manual update. > > Sadly, I expect this trend of using GH_* for ports to be growing, so new > and old-but-upstream-changed-with-update ports would benefit from such > an automatic default. This diff changes nothing for GH_* ports. (Actually I wonder if the implicit default for GH_* is responsible for some of these - imported as GH_*, later changed to MASTER_SITES=...github...releases/..., that's when it's easy to forget to add the HOMEPAGE). > If not, I'll probably just drop the idea. I'd certainly support adding explicit HOMEPAGE entries for the ports you've identified here, and same for some kind of portcheck addition (even if it's just "no HOMEPAGE set, can you find something to use?" I just realised something else: if a distfile changes upstream and I need to mirror the old version, I don't expect a MASTER_SITES change to require a REVISION bump. But that's exactly what will happen with this change. > Index: share/man/man5/bsd.port.mk.5 > =================================================================== > RCS file: /cvs/src/share/man/man5/bsd.port.mk.5,v > retrieving revision 1.550 > diff -u -p -r1.550 bsd.port.mk.5 > --- share/man/man5/bsd.port.mk.5 22 Nov 2021 11:17:39 -0000 1.550 > +++ share/man/man5/bsd.port.mk.5 9 Dec 2021 00:54:23 -0000 > @@ -1945,6 +1945,9 @@ Location of the GNU make binary, if need > Defaults to gmake. > .It Ev HOMEPAGE > URL to the homepage of the software, if applicable. > +Defaults to the GitHub repository URL if > +.Ev MASTER_SITES > +is a GitHub project. > .It Ev IGNORE > For ignored ports, set to the reasons for which the port is ignored. > If non-empty, most common targets that do something (e.g., > > > Index: infrastructure/mk/bsd.port.mk > =================================================================== > RCS file: /cvs/ports/infrastructure/mk/bsd.port.mk,v > retrieving revision 1.1563 > diff -u -p -r1.1563 bsd.port.mk > --- infrastructure/mk/bsd.port.mk 27 Nov 2021 16:46:13 -0000 1.1563 > +++ infrastructure/mk/bsd.port.mk 9 Dec 2021 00:43:55 -0000 > @@ -1252,6 +1252,14 @@ HOMEPAGE ?= https://github.com/${GH_ACCO > .else > # Empty declarations to avoid "variable XXX is recursive" errors > MASTER_SITES ?= > + > +# default to the repository URL if MASTER_SITES is GitHub/author/repo/... > +_GH_MASTER_URL = ${MASTER_SITES:Mhttps\://github.com/*/*/*} > +. if !empty(_GH_MASTER_URL) > +# cut down to /author/repo > +HOMEPAGE ?= ${_GH_MASTER_URL:C,(https\://github.com(/[^/]+){2}).*,\1,1} > +. endif > + > .endif > > # I guess we're in the master distribution business! :) As we gain mirror > Index: devel/arduino-esp32/Makefile > =================================================================== > RCS file: /cvs/ports/devel/arduino-esp32/Makefile,v > retrieving revision 1.7 > diff -u -p -r1.7 Makefile > --- devel/arduino-esp32/Makefile 18 Nov 2021 16:03:23 -0000 1.7 > +++ devel/arduino-esp32/Makefile 9 Dec 2021 00:50:00 -0000 > @@ -4,6 +4,7 @@ COMMENT = esp32 arduino core toolset > V = 2.0.1 > DISTNAME = esp32-${V} > PKGNAME = arduino-${DISTNAME} > +REVISION = 0 > > CATEGORIES = devel > > Index: devel/arduino-esp8266/Makefile > =================================================================== > RCS file: /cvs/ports/devel/arduino-esp8266/Makefile,v > retrieving revision 1.9 > diff -u -p -r1.9 Makefile > --- devel/arduino-esp8266/Makefile 2 Nov 2021 00:00:23 -0000 1.9 > +++ devel/arduino-esp8266/Makefile 9 Dec 2021 00:49:58 -0000 > @@ -4,7 +4,7 @@ COMMENT = esp8266 arduino core toolset > V = 3.0.2 > DISTNAME = esp8266-${V} > PKGNAME = arduino-${DISTNAME} > -REVISION = 0 > +REVISION = 1 > > CATEGORIES = devel > > Index: devel/cargo-generate-vendor/Makefile > =================================================================== > RCS file: /cvs/ports/devel/cargo-generate-vendor/Makefile,v > retrieving revision 1.3 > diff -u -p -r1.3 Makefile > --- devel/cargo-generate-vendor/Makefile 12 Jul 2019 20:44:05 -0000 > 1.3 > +++ devel/cargo-generate-vendor/Makefile 9 Dec 2021 00:49:59 -0000 > @@ -4,7 +4,7 @@ COMMENT = help generating metadata for c > > V = 1.0 > DISTNAME = cargo-generate-vendor-${V} > -REVISION = 0 > +REVISION = 1 > > CATEGORIES = devel > > Index: devel/harfbuzz/Makefile > =================================================================== > RCS file: /cvs/ports/devel/harfbuzz/Makefile,v > retrieving revision 1.138 > diff -u -p -r1.138 Makefile > --- devel/harfbuzz/Makefile 27 Nov 2021 10:00:48 -0000 1.138 > +++ devel/harfbuzz/Makefile 9 Dec 2021 00:49:58 -0000 > @@ -4,6 +4,8 @@ BROKEN-hppa= no atomic primitives > > COMMENT-main= text shaping library > COMMENT-icu= ICU support for libharfbuzz > +REVISION-icu= 0 > +REVISION-main= 0 > > V= 3.1.2 > DISTNAME= harfbuzz-${V} > Index: fonts/cascadia-code/Makefile > =================================================================== > RCS file: /cvs/ports/fonts/cascadia-code/Makefile,v > retrieving revision 1.8 > diff -u -p -r1.8 Makefile > --- fonts/cascadia-code/Makefile 17 Nov 2021 10:29:26 -0000 1.8 > +++ fonts/cascadia-code/Makefile 9 Dec 2021 00:49:59 -0000 > @@ -6,6 +6,7 @@ DISTNAME = CascadiaCode-${V} > PKGNAME = cascadia-code-${V} > EXTRACT_SUFX = .zip > CATEGORIES = fonts x11 > +REVISION = 0 > > # SIL OFL 1.1 > PERMIT_PACKAGE = Yes > Index: fonts/mada/Makefile > =================================================================== > RCS file: /cvs/ports/fonts/mada/Makefile,v > retrieving revision 1.2 > diff -u -p -r1.2 Makefile > --- fonts/mada/Makefile 12 Jul 2019 20:46:12 -0000 1.2 > +++ fonts/mada/Makefile 9 Dec 2021 00:50:01 -0000 > @@ -4,6 +4,7 @@ COMMENT = modernist Arabic typeface > > V = 1.3 > DISTNAME = mada-${V} > +REVISION = 0 > > CATEGORIES = fonts > > Index: games/irrlamb/Makefile > =================================================================== > RCS file: /cvs/ports/games/irrlamb/Makefile,v > retrieving revision 1.12 > diff -u -p -r1.12 Makefile > --- games/irrlamb/Makefile 12 Jul 2019 20:46:19 -0000 1.12 > +++ games/irrlamb/Makefile 9 Dec 2021 00:49:59 -0000 > @@ -5,7 +5,7 @@ COMMENT = third person, 3D physics game > DISTNAME = irrlamb-$V-src > PKGNAME = irrlamb-$V > CATEGORIES = games x11 > -REVISION = 2 > +REVISION = 3 > > # GPLv3+ > PERMIT_PACKAGE = Yes > Index: graphics/mypaint-brushes/Makefile > =================================================================== > RCS file: /cvs/ports/graphics/mypaint-brushes/Makefile,v > retrieving revision 1.5 > diff -u -p -r1.5 Makefile > --- graphics/mypaint-brushes/Makefile 18 May 2020 14:48:05 -0000 1.5 > +++ graphics/mypaint-brushes/Makefile 9 Dec 2021 00:50:00 -0000 > @@ -6,6 +6,7 @@ COMMENT = brushes used by software using > V = 1.3.1 > DISTNAME = mypaint-brushes-$V > EXTRACT_SUFX = .tar.xz > +REVISION = 0 > > CATEGORIES = graphics > > Index: graphics/mypaint-brushes2/Makefile > =================================================================== > RCS file: /cvs/ports/graphics/mypaint-brushes2/Makefile,v > retrieving revision 1.1.1.1 > diff -u -p -r1.1.1.1 Makefile > --- graphics/mypaint-brushes2/Makefile 12 Sep 2020 20:33:11 -0000 > 1.1.1.1 > +++ graphics/mypaint-brushes2/Makefile 9 Dec 2021 00:50:01 -0000 > @@ -6,6 +6,7 @@ V = 2.0.2 > DISTNAME = mypaint-brushes-$V > PKGNAME = mypaint-brushes2-$V > EXTRACT_SUFX = .tar.xz > +REVISION = 0 > > CATEGORIES = graphics > > Index: graphics/ocaml-graphics/Makefile > =================================================================== > RCS file: /cvs/ports/graphics/ocaml-graphics/Makefile,v > retrieving revision 1.3 > diff -u -p -r1.3 Makefile > --- graphics/ocaml-graphics/Makefile 2 Dec 2021 03:59:20 -0000 1.3 > +++ graphics/ocaml-graphics/Makefile 9 Dec 2021 00:49:58 -0000 > @@ -4,7 +4,7 @@ COMMENT = graphics library providing bas > CATEGORIES = graphics > > V = 5.0.0 > -REVISION = 1 > +REVISION = 2 > DISTNAME = graphics-$V > PKGNAME = ocaml-graphics-$V > > Index: graphics/scrot/Makefile > =================================================================== > RCS file: /cvs/ports/graphics/scrot/Makefile,v > retrieving revision 1.19 > diff -u -p -r1.19 Makefile > --- graphics/scrot/Makefile 29 Aug 2021 10:39:39 -0000 1.19 > +++ graphics/scrot/Makefile 9 Dec 2021 00:50:00 -0000 > @@ -4,6 +4,7 @@ COMMENT= commandline screen capture uti > > V= 1.6 > DISTNAME= scrot-${V} > +REVISION= 0 > > CATEGORIES= graphics > > Index: mail/fdm/Makefile > =================================================================== > RCS file: /cvs/ports/mail/fdm/Makefile,v > retrieving revision 1.25 > diff -u -p -r1.25 Makefile > --- mail/fdm/Makefile 23 Jan 2021 23:17:48 -0000 1.25 > +++ mail/fdm/Makefile 9 Dec 2021 00:50:00 -0000 > @@ -5,7 +5,7 @@ COMMENT= fetch, filter and deliver mail > V= 2.0 > DISTNAME= fdm-$V > CATEGORIES= mail > -REVISION= 1 > +REVISION= 2 > > MAINTAINER= Nicholas Marriott <n...@openbsd.org> > > Index: mail/greyscanner/Makefile > =================================================================== > RCS file: /cvs/ports/mail/greyscanner/Makefile,v > retrieving revision 1.15 > diff -u -p -r1.15 Makefile > --- mail/greyscanner/Makefile 30 Nov 2020 15:41:56 -0000 1.15 > +++ mail/greyscanner/Makefile 9 Dec 2021 00:50:02 -0000 > @@ -4,7 +4,7 @@ COMMENT = greytrapping daemon to complem > > DISTNAME = greyscanner-2.01 > CATEGORIES = mail > -REVISION = 1 > +REVISION = 2 > > # BSD > PERMIT_PACKAGE = Yes > Index: misc/rlwrap/Makefile > =================================================================== > RCS file: /cvs/ports/misc/rlwrap/Makefile,v > retrieving revision 1.15 > diff -u -p -r1.15 Makefile > --- misc/rlwrap/Makefile 12 Nov 2021 14:33:04 -0000 1.15 > +++ misc/rlwrap/Makefile 9 Dec 2021 00:50:01 -0000 > @@ -5,6 +5,7 @@ COMMENT= generic readline wrapper for v > V = 0.45.2 > DISTNAME= rlwrap-$V > CATEGORIES= misc > +REVISION= 0 > > # GPLv2 > PERMIT_PACKAGE= Yes > Index: misc/zzuf/Makefile > =================================================================== > RCS file: /cvs/ports/misc/zzuf/Makefile,v > retrieving revision 1.20 > diff -u -p -r1.20 Makefile > --- misc/zzuf/Makefile 12 Jul 2019 20:47:55 -0000 1.20 > +++ misc/zzuf/Makefile 9 Dec 2021 00:50:00 -0000 > @@ -6,6 +6,7 @@ COMMENT= transparent application input > > VERSION= 0.15 > DISTNAME= zzuf-${VERSION} > +REVISION= 0 > > CATEGORIES= misc security > > Index: multimedia/webvfx/Makefile > =================================================================== > RCS file: /cvs/ports/multimedia/webvfx/Makefile,v > retrieving revision 1.2 > diff -u -p -r1.2 Makefile > --- multimedia/webvfx/Makefile 20 May 2020 15:16:26 -0000 1.2 > +++ multimedia/webvfx/Makefile 9 Dec 2021 00:50:01 -0000 > @@ -6,6 +6,7 @@ COMMENT = video effects library > V = 1.2.0 > DISTNAME = webvfx-$V > DISTFILES = webvfx-{}$V${EXTRACT_SUFX} > +REVISION = 0 > > SHARED_LIBS += webvfx 0.0 # 1.2 > > Index: net/gelatod/Makefile > =================================================================== > RCS file: /cvs/ports/net/gelatod/Makefile,v > retrieving revision 1.3 > diff -u -p -r1.3 Makefile > --- net/gelatod/Makefile 23 Nov 2021 23:48:05 -0000 1.3 > +++ net/gelatod/Makefile 9 Dec 2021 00:49:59 -0000 > @@ -4,6 +4,7 @@ COMMENT = CLAT configuration daemon for > V = 1.3 > DISTNAME = gelatod-${V} > CATEGORIES = net > +REVISION = 0 > > # BSD 2-clause > PERMIT_PACKAGE = Yes > Index: net/oicb/Makefile > =================================================================== > RCS file: /cvs/ports/net/oicb/Makefile,v > retrieving revision 1.10 > diff -u -p -r1.10 Makefile > --- net/oicb/Makefile 6 Mar 2021 23:08:16 -0000 1.10 > +++ net/oicb/Makefile 9 Dec 2021 00:49:59 -0000 > @@ -4,6 +4,7 @@ VERSION = 1.3.0 > DISTNAME = oicb-${VERSION} > CATEGORIES = net > MAINTAINER = Vadim Zhukov <z...@openbsd.org> > +REVISION = 0 > > # 2-clause BSD > PERMIT_PACKAGE = Yes > Index: net/telegram-purple/Makefile > =================================================================== > RCS file: /cvs/ports/net/telegram-purple/Makefile,v > retrieving revision 1.8 > diff -u -p -r1.8 Makefile > --- net/telegram-purple/Makefile 4 Jan 2021 11:56:28 -0000 1.8 > +++ net/telegram-purple/Makefile 9 Dec 2021 00:49:59 -0000 > @@ -8,6 +8,7 @@ COMMENT = Telegram support for Pidgin > DISTNAME = telegram-purple_$V.orig > PKGNAME = telegram-purple-$V > CATEGORIES = net > +REVISION = 0 > > # GPLv2+ > PERMIT_PACKAGE = Yes > Index: print/system-config-printer/Makefile > =================================================================== > RCS file: /cvs/ports/print/system-config-printer/Makefile,v > retrieving revision 1.62 > diff -u -p -r1.62 Makefile > --- print/system-config-printer/Makefile 2 Nov 2021 00:01:54 -0000 > 1.62 > +++ print/system-config-printer/Makefile 9 Dec 2021 00:50:00 -0000 > @@ -4,7 +4,7 @@ COMMENT= printer (CUPS) administration > > V= 1.5.15 > DISTNAME= system-config-printer-${V} > -REVISION= 0 > +REVISION= 1 > > CATEGORIES= print sysutils > > Index: productivity/mcds/Makefile > =================================================================== > RCS file: /cvs/ports/productivity/mcds/Makefile,v > retrieving revision 1.7 > diff -u -p -r1.7 Makefile > --- productivity/mcds/Makefile 5 Oct 2020 19:46:17 -0000 1.7 > +++ productivity/mcds/Makefile 9 Dec 2021 00:50:01 -0000 > @@ -5,7 +5,7 @@ COMMENT = tty-based CardDav search tool > V = 1.6 > DISTNAME = mcds-${V} > CATEGORIES = productivity > -REVISION = 1 > +REVISION = 2 > > MAINTAINER = Timothy Brown <tbr...@freeshell.org> > > Index: security/tls-attacker/Makefile > =================================================================== > RCS file: /cvs/ports/security/tls-attacker/Makefile,v > retrieving revision 1.2 > diff -u -p -r1.2 Makefile > --- security/tls-attacker/Makefile 19 May 2021 01:50:31 -0000 1.2 > +++ security/tls-attacker/Makefile 9 Dec 2021 00:50:02 -0000 > @@ -5,7 +5,7 @@ COMMENT = framework for analyzing TLS l > V = 3.5.0 > DISTNAME = TLS-Attacker-$V > PKGNAME = ${DISTNAME:L} > -REVISION = 0 > +REVISION = 1 > > MAINTAINER = Jasper Lievisse Adriaanse <jas...@openbsd.org> > > Index: sysutils/patchelf/Makefile > =================================================================== > RCS file: /cvs/ports/sysutils/patchelf/Makefile,v > retrieving revision 1.8 > diff -u -p -r1.8 Makefile > --- sysutils/patchelf/Makefile 6 Dec 2021 19:26:45 -0000 1.8 > +++ sysutils/patchelf/Makefile 9 Dec 2021 00:50:01 -0000 > @@ -5,6 +5,7 @@ COMMENT = utility for modifying existing > V = 0.14.3 > DISTNAME = patchelf-${V} > MASTER_SITES = > https://github.com/NixOS/patchelf/releases/download/${V}/ > +REVISION = 0 > > CATEGORIES = sysutils > > Index: x11/lablgtk3/Makefile > =================================================================== > RCS file: /cvs/ports/x11/lablgtk3/Makefile,v > retrieving revision 1.9 > diff -u -p -r1.9 Makefile > --- x11/lablgtk3/Makefile 5 Dec 2021 13:28:56 -0000 1.9 > +++ x11/lablgtk3/Makefile 9 Dec 2021 00:50:02 -0000 > @@ -5,7 +5,7 @@ CATEGORIES = x11 devel > > V = 3.1.1 > DISTNAME = lablgtk3-${V} > -REVISION = 2 > +REVISION = 3 > > MASTER_SITES = > https://github.com/garrigue/lablgtk/releases/download/${V}/ > EXTRACT_SUFX = .tbz >
