Penned by Landry Breuil on 20210410 2:05.48, we have: | On Fri, Apr 09, 2021 at 04:53:17PM +0200, Landry Breuil wrote: | > On Thu, Apr 08, 2021 at 06:19:58PM +0200, Jeroen Derks wrote: | > > On 08/04/2021 14:35, Landry Breuil wrote:> | > > > well that's very nice, definitely interested in those freebsd patches ! | > > > not 100% sure those will get in 6.9 though as we're slowly moving towards | > > > lock, but send them anyway, and we'll figure out what we can do from | > > > there. I suppose those come from https://github.com/aborche/qemu-guest-agent ? | > > | > > Indeed, here they are (if there's interest I can also send a diff of the patches | > > compared to the FreeBSD patches to see what I've done): | > | > oh, well that looks nice. A bit rought around the edges imo, and im not | > sure we want to maintain a rather large patch like this in the | > portstree. according to https://wiki.qemu.org/Contribute/SubmitAPatch i | > think it should be pushed upstream, do you have any idea if the original | > freebsd patches were proposed there or qemu-devel list ? | > | > i'll let brad decide, but as is this doesnt apply as-is against 6.0 rcs | > which we're testing for post-6.9.... | | so i've backported your patch on top of brad's 6.0rc2 qemu update, and | fixed things here and there, removed commented code, and yeah get-vcpus, | get-fsinfo and network-get-interfaces seems to work fine ! | | i'm not sure we want the set user password thing in the patch, as it | wont work on openbsd (uses the pw command which is freebsd ?). It's also | a bit gross to exec df to fetch the mount point list.. | | im also not sure what to do with the localstatedir thing (the -t flag), | i've added --localstatedir=/tmp/ to CONFIGURE_ARGS but that feels wrong. | qga needs it to store its qga.state file and probably to store temp | files..
Why is /var/run (the default) not a good option? Is there a reason we don't want to provide an example /etc/qemu/ga.conf ? Thanks, -- Todd T. Fries . http://todd.fries.net/pgp.txt . @unix2mars . github:toddfries
