On Mon, Jan 10, 2022 at 09:17:52AM +0100, Stefan Hagen wrote: > Stefan Hagen wrote: > > > 2) the port needs a registered telegram application and the API_ID and > > > API_HASH needs to be passed at build time. You can do so in the port > > > Makefile. > > > > OpenBSD devs can use my key in cvs:~sdk/tdlib_api to test. Please > > don't use it for anything else. I'll invalidate it at some point. > > Attached is the next version plus a cherry picked pull request[1] that > moves the API key definition out from compile time to runtime. > > When adding the tdlib-telegram account, you can add the API key in the > UI. In pidgin it's on the advanced tab on the add-account screen.
That's a good thing! > [1] https://github.com/ars3niy/tdlib-purple/pull/129 What's CONFLICT_MARKER for? I can't find any reference to it. V can be merged into GH_TAGNAME. BUILD_DEPENDS can be sorted. I find it cleaner to just amend CXXFLAGS rather than passing CMAKE_CXXFLAGS; the latter picks up CXXFLAGS anyway. NO_TEST=yes should be removed for broken tests. While here, you could comment on *why* they're broken and/or what exactly is missing. The CMakeLists.txt and tdlib-purple.nsi (latter missing a comment) patches might be done in a post-install hunk. All other patches related to pull/129 can be replaced with this: MASTER_SITES0 = https://github.com/ars3niy/tdlib-purple/commit/ PATCHFILES = configurable-api-token-{}77ac43ac.patch:0 PATCH_DIST_STRIP = -p1
