On 2022/01/17 08:20, Stefan Hagen wrote: > Hi Laurent, > > [email protected] wrote: > > Hi, > > > > [sorry for my previous crap post] > > This one is mangled too :-) Your editor made spaces out of the tabs. > > > I updated sysutils/fzf port to the last version 0.29.0 => > > https://github.com/junegunn/fzf/releases/tag/0.29.0 > > > > I used GitHub repository to fetch sources package for v0.29.0 version and > > created specific package including Go modules. > > > > $ make fetch > > $ cd /usr/distfiles > > $ mv fzf-0.29.0-dc975e89.tar.gz fzf-0.29.0-dc975e89.orig.tar.gz > > $ tar xzvf fzf-0.29.0-dc975e89.orig.tar.gz > > $ cd fzf-dc975e8974c4f569980676d9f605226368e20711 > > $ go mod vendor > > $ cd .. > > $ tar cvpf fzf-0.29.0-dc975e89.tar.gz > > fzf-dc975e8974c4f569980676d9f605226368e20711 > > > > Update distinfo file with make makesum > > Hmm, yes, but there must be no manual steps between "make fetch" and > "make package". The build servers won't perform these ;-) > > This is, why Edd is hosting a tarball with this change on his website, > which is then used in MASTER_SITES. > > So your change to github won't work. Sorry. > > > make build/package/install and tests OK on OpenBSD 7.0/amd64. > > When submitting a port, it's good practice to test it on a -current > system. As least if you're planning to submit more often. > > Even though we can't commit this port, I gave you more feedback below > for your next port maybe? > > Thanks for your effort. > > Best Regards, > Stefan > > > Index: Makefile > > =================================================================== > > RCS file: /cvs/ports/sysutils/fzf/Makefile,v > > retrieving revision 1.12 > > diff -u -p -r1.12 Makefile > > --- Makefile 6 May 2021 11:15:41 -0000 1.12 > > +++ Makefile 16 Jan 2022 07:29:09 -0000 > > @@ -4,11 +4,15 @@ COMMENT = command-line fuzzy finder > > > > # Note: we make our own vendored distfile as upstream doesn't do semantic > > # versioning. Use 'go mod vendor'. > > -DISTNAME = fzf-0.24.1 > > -REVISION = 2 > > +DISTNAME = fzf-0.29.0 > > +REVISION = 1 > > When the DISTNAME changes (due to version bump), REVISION can be removed > entirely. Also, REVISION starts at 0. > > > CATEGORIES = sysutils > > > > +GH_ACCOUNT = junegunn > > +GH_PROJECT = fzf > > +GH_COMMIT = dc975e8974c4f569980676d9f605226368e20711 # v.0.29 git tag > > Try to avoid GH_COMMIT where possible. In this case, you could have used > GH_TAGNAME= 0.29.0
That's bogus anyway for a distfile which is not fetched from github.
