On Fri, Feb 18, 2022 at 03:53:25PM +0000, Klemens Nanni wrote:
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/databases/xapian-bindings/Makefile,v
> > retrieving revision 1.37
> > diff -u -p -r1.37 Makefile
> > --- Makefile 9 Jan 2022 12:12:39 -0000 1.37
> > +++ Makefile 18 Feb 2022 15:24:40 -0000
> > @@ -49,8 +49,7 @@ SUBST_VARS+= MODRUBY_BINREV
> >
> > CONFIGURE_STYLE= autoconf
> > AUTOCONF_VERSION= 2.69
> > -CONFIGURE_ENV= RUBY="${RUBY}" RDOC="${RUBY:S/ruby/rdoc/}" \
> > - CXXFLAGS="${CXXFLAGS} -fdeclspec"
> > +CONFIGURE_ENV= RUBY="${RUBY}" RDOC="${RUBY:S/ruby/rdoc/}"
> > CONFIGURE_ARGS= --with-perl \
> > --with-python3 \
> > --with-ruby \
> That won't pass CXXFLAGS on !clang archs any longer, is that intended?
> Or is is still picked up correctly?
It wasn't passed at all until the -fdeclspec stuff was added in
r1.35. So I think that's the only reason it was passed.
--Kurt
> > @@ -66,5 +65,10 @@ pre-configure:
> >
> > post-install:
> > mv ${PREFIX}/share/doc/xapian-bindings/ruby{,${MODRUBY_BINREV}}
> > +
> > +.include <bsd.port.arch.mk>
> > +.if ${PROPERTIES:Mclang}
> > +CONFIGURE_ENV += CXXFLAGS="${CXXFLAGS} -fdeclspec"
> > +.endif
> >
> > .include <bsd.port.mk>
> >
>
> Why not keep passing CXXFLAGS in CONFIGURE_ENV and conditionally
> amending CXXFLAGS here?
>
> CONFIGURE_ENV = CXXFLAGS=${CXXFLAGS}
>
> .if clang
> CXXFLAGS += ...
> .endif
>
