On Sat 19/02/2022 07:39, Lucas Raab wrote: > On Sat, Feb 19, 2022 at 07:33:54AM +0100, Bjorn Ketelaars wrote: > > On Fri 18/02/2022 20:32, Lucas Raab wrote: > > > Hello, > > > > > > Here's a new port for py-rx, or Reactive Extensions, "a set of > > > libraries for composing asynchronous and event-based programs using > > > observable sequences and pipable query operators in Python". This > > > is needed for an update to the Python influxdb port (coming soon). > > > > > > Feedback? > > > > > > Thanks, > > > Lucas > > > > Homepage can be switched to https. You are using > > MODPY_VERSION=${MODPY_DEFAULT_VERSION_3} and FLAVORS/FLAVOR=python3. > > Setting both is not necessary, and MODPY_VERSION should be removed as > > py-rx is not a standalone program. pkg/DESCR contains a trailing > > newline, which can be removed. > > > > It builds and packages. Tarball does not contain the required test > > files, so make test does not work. > > Thanks, Bjorn > > Updates have been made and are in this new version. I also switched > to using GH_* so the tests dir is now present. Tests pass with some > Python 3.10 deprecation warnings. > > How's this one look?
Being able to run tests has its value, and switching to GH_* does make sense. I can confirm that all tests pass. Why not drop DISTNAME and just set PKGNAME (and as a result update distinfo)? See diff below. While here move GH_* a couple of lines up. With the diff below OK bket@. I can import this port if there is another OK, or someone else can do it. diff --git Makefile Makefile index c6ab435ec7a..6454fd9ad3c 100644 --- Makefile +++ Makefile @@ -3,9 +3,10 @@ COMMENT = library for asynchronous and event-based programs in Python MODPY_EGG_VERSION = 3.2.0 - -DISTNAME = Rx-${MODPY_EGG_VERSION} -PKGNAME = py-${DISTNAME:L} +GH_ACCOUNT = ReactiveX +GH_PROJECT = RxPY +GH_TAGNAME = v${MODPY_EGG_VERSION} +PKGNAME = py-rx-${MODPY_EGG_VERSION} CATEGORIES = devel @@ -19,10 +20,6 @@ MODULES = lang/python MODPY_SETUPTOOLS = Yes MODPY_PYTEST = Yes -GH_ACCOUNT = ReactiveX -GH_PROJECT = RxPY -GH_TAGNAME = v${MODPY_EGG_VERSION} - FLAVORS = python3 FLAVOR = python3 diff --git distinfo distinfo index d0d9a14abed..8a2bcadc60f 100644 --- distinfo +++ distinfo @@ -1,2 +1,2 @@ -SHA256 (Rx-3.2.0.tar.gz) = K2zSdaPkZB0w/eiNoBL0cNjOo9I7H0Ku8CQ8L8GZ56o= -SIZE (Rx-3.2.0.tar.gz) = 891490 +SHA256 (RxPY-3.2.0.tar.gz) = K2zSdaPkZB0w/eiNoBL0cNjOo9I7H0Ku8CQ8L8GZ56o= +SIZE (RxPY-3.2.0.tar.gz) = 891490