On Thu, Mar 03, 2022 at 11:30:54AM +0100, Stefan Hagen wrote: > Marc Espie wrote (2022-03-03 10:48 CET): > > On Sat, Feb 19, 2022 at 10:26:15PM +0100, Omar Polo wrote: > > > Michael <michi+open...@dataswamp.org> writes: > > > > > > > On Sun, Feb 13, 2022 at 05:53:13PM +0100, Rafael Sadowski wrote: > > > >> [...] > > > >> Thanks Michael! > > > >> > > > >> OK rsadowski@ if someone wants to import it. > > > >> > > > > > > > > Ping. > > > > > > There are a couple of sprintf(%n) in there that will crash the window > > > manager if those code paths are reached, I'm attaching an updated > > > tarball with those patched (plus a patch for another sprintf call > > > involving time_t.) > > > > > > Otherwise it builds fine, the port looks good and it seems to work! :) > > > > > > (i'm typing this mail from fvwm3 with default config) > > > > > > it's ok op@ to import > > > > I'm running it. I'm also okay for import, unless there are objections. > > > > Quite a few of those sprintf if not all should be snprintf eventually, but > > we should work in-tree and talk to upstream > > I imported fvwm3 a week ago and the %n fixes are merged upstream > already. See https://github.com/fvwmorg/fvwm3/pull/653
Most sprintf should move to snprintf... just tracking down the ones in the proposed patches is already scary ;)
