I think it is too late to switch the main go ports builds to 1.18, it looks like a lot has changed in this release, and by nature Go is fairly machine-dependent. It's going to be pushing it for time to fix any problems found especially considering that it is rather painful to patch ports using go modules.
However it could be added as a separate alternative port, I guess it would be fiddly to de-conflict with the main lang/go, but as long as nothing BUILD_DEPENDS on it then it could be set to conflict with 1.17. This would allow including packages of go 1.18 in the release, then post-release we can merge it back into lang/go and use it in builds too. On 2022/03/28 12:24, Aaron Bieber wrote: > > Aaron Bieber <[email protected]> writes: > > > Joel Sing <[email protected]> writes: > > > >> The following updates lang/go to 1.18. > >> > >> This has been tested on amd64 and arm64 - it still needs to be tested > >> (including 'make regress') on armv7 and mips64. > >> > >> It would probably also be a good idea to have this go through a bulk > >> (or at least a build of all Go ports), although I expect less fallout > >> than with some of the other major updates. > >> > > > > I have my mips64 box building now.. sysupgrading the armv7 and will kick > > off a build once that is done! > > amd64 minibulk: > Elapsed time=03:44:03 > I=536 B=12 Q=0 T=37 F=0 !=1 > E=devel/spidermonkey78 net/go-ipfs devel/git security/gnutls > net/dendrite textproc/ruby-ronn > > net/dendrite is fixed by an upgrade to 0.7.0 > > net/go-ipfs is broken, seems the latest version (not committed yet) > still uses an old quic-go: > ../../../go/pkg/mod/github.com/lucas-clemente/[email protected]/internal/qtls/go118.go:6:13: > cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string > constant) as int value in variable declaration > > mips64 failure: > > ok cmd/internal/sys 0.076s > ok cmd/internal/test2json 0.392s > --- FAIL: TestIndexMismatch (1.42s) > link_test.go:769: /build/pobj/go-1.18/go/bin/go tool compile -o > /tmp/TestIndexMismatch603320231/001/a.o testdata/testIndexMismatch/a.go > link_test.go:775: /build/pobj/go-1.18/go/bin/go tool compile -I > /tmp/TestIndexMismatch603320231/001 -o > /tmp/TestIndexMismatch603320231/001/main.o testdata/testIndexMismatch/main.go > link_test.go:781: /build/pobj/go-1.18/go/bin/go tool link -L > /tmp/TestIndexMismatch603320231/001 -o > /tmp/TestIndexMismatch603320231/001/main.exe > /tmp/TestIndexMismatch603320231/001/main.o > link_test.go:784: linking failed: exit status 1 > /build/pobj/go-1.18/go/pkg/tool/openbsd_mips64/link: running gcc failed: > exec: "gcc": executable file not found in $PATH > > link_test.go:790: /build/pobj/go-1.18/go/bin/go tool compile -o > /tmp/TestIndexMismatch603320231/001/a.o testdata/testIndexMismatch/b.go > link_test.go:796: /build/pobj/go-1.18/go/bin/go tool link -L > /tmp/TestIndexMismatch603320231/001 -o > /tmp/TestIndexMismatch603320231/001/main.exe > /tmp/TestIndexMismatch603320231/001/main.o > --- FAIL: TestIssue28429 (1.30s) > link_test.go:96: 'go tool link main.a' failed: exit status 1, output: > /build/pobj/go-1.18/go/pkg/tool/openbsd_mips64/link: running gcc failed: > exec: "gcc": executable file not found in $PATH > > --- FAIL: TestIssue21703 (1.18s) > link_test.go:69: failed to link main.o: exit status 1, output: > /build/pobj/go-1.18/go/pkg/tool/openbsd_mips64/link: running gcc failed: > exec: "gcc": executable file not found in $PATH > > > --- FAIL: TestMergeNoteSections (2.87s) > elf_test.go:230: # command-line-arguments > /build/pobj/go-1.18/go/pkg/tool/openbsd_mips64/link: running cc failed: exit > status 1 > /usr/bin/ld: unrecognized option > '--build-id=0xf4e8cd51ce8bae2996dc3b74639cdeaa1f7fee5f' > /usr/bin/ld: use the --help option for usage information > cc: error: linker command failed with exit code 1 (use -v to see invocation) > > elf_test.go:231: exit status 2 > FAIL > FAIL cmd/link 113.987s > ok cmd/link/internal/benchmark 0.035s > ok cmd/link/internal/ld 122.645s > ok cmd/link/internal/loader 0.111s > ok cmd/nm 21.697s > ok cmd/objdump 8.050s > --- FAIL: TestHello (7.03s) > pack_test.go:382: [/build/pobj/go-1.18/go/bin/go tool link -o a.out hello.a]: > exit status 1 > /build/pobj/go-1.18/go/pkg/tool/openbsd_mips64/link: running gcc failed: > exec: "gcc": executable file not found in $PATH > > FAIL > FAIL cmd/pack 24.376s > ok cmd/pprof 16.426s > ok cmd/trace 4.063s > ok cmd/vet 140.928s > FAIL > go tool dist: Failed: exit status 1 > *** Error 1 in /usr/ports/lang/go (Makefile:123 'do-test': @cd > /build/pobj/go-1.18/go/src && ulimit -d $(ulimit -H -d) -n 256 && > /usr/bin/...) > *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2996 > '/build/pobj/go-1.18/build-mips64/.test_done': @cd /usr/ports/lang/go && > exe...) > *** Error 2 in /usr/ports/lang/go > (/usr/ports/infrastructure/mk/bsd.port.mk:2607 'test': @lock=go-1.18; export > _LOCKS_HELD=" go-1.18"; sud...) > qbit@eri[2]:/usr/ports/lang/go git:(go1.18)$ >
