Hello, Florian Viehweger <open...@out-of-creativity.de> wrote: > Hi, > > this updates chafa to 1.12.0. > > Changes are listed here[1]. > The biggest change is probably dropping ImageMagick.
just for context: upstream made the dependency on ImageMagick optional and deprecated it, encouraging packagers to drop it. > Some testing done on amd64. No issues found. > I will test i386 soonish and send a follow-up mail. > > Tests on big endian architectures welcome. > > portcheck, 'make lib-depends-check' and 'make test' are happy. > > Comments? 1.12.1 was released yesterday with a few security fixes ;-) https://github.com/hpjansson/chafa/releases/tag/1.12.1 unfortunately upstream doesn't list which versions are affected by those issues. it raises the question if we should update on -STABLE too thought. > -SHARED_LIBS += chafa 2.1 # 7.0 > +SHARED_LIBS += chafa 3.0 # 2.1 check_sym only shows added symbols (the "External reference changes" doesn't matter here), but the project has a history of changing subtle things in the headers, the version change and the corresponding diff long enough that I agree with a major bump here. No other port links to libchafa anyway. nitpick: usually the format for SHARED_LIBS is: name our version # upstream version "upstream version" is not needed strictly speaking, but it's nice to have sometimes. in this case, upstream installs libchafa.so.8.1, so the comment should be with 8.1 and not 2.1 which is the version *we* used in the previous version. > [..] > COMPILER = base-clang ports-gcc > +CONFIGURE_ARGS += --without-imagemagick nitpick: I'd move CONFIGURE_ARGS closer to CONFIGURE_STYLE here's an updated diff, lightly tested with some gifs and pngs, works fine as usual for me :) Index: Makefile =================================================================== RCS file: /home/cvs/ports/graphics/chafa/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile --- Makefile 22 Mar 2022 08:49:35 -0000 1.7 +++ Makefile 21 Jun 2022 10:10:09 -0000 @@ -1,7 +1,7 @@ COMMENT = character art facsimile generator -DISTNAME = chafa-1.10.0 +DISTNAME = chafa-1.12.1 -SHARED_LIBS += chafa 2.1 # 7.0 +SHARED_LIBS += chafa 3.0 # 8.1 CATEGORIES = graphics @@ -12,11 +12,13 @@ MAINTAINER = Florian Viehweger <openbsd # LGPLv3+ PERMIT_PACKAGE = Yes -WANTLIB += ICE MagickCore-6.Q16 MagickWand-6.Q16 SM X11 Xext Xt -WANTLIB += aom bz2 c dav1d de265 djvulibre expat fontconfig -WANTLIB += freetype glib-2.0 heif iconv intl jasper jbig jpeg -WANTLIB += lcms2 lzma m openjp2 pcre png pthread raw_r tiff webp -WANTLIB += webpdemux webpmux x265 xcb xml2 z zstd +WANTLIB += X11 Xau Xdmcp Xext Xrender c cairo cairo-gobject +WANTLIB += cairo-gobject expat ffi fontconfig freetype +WANTLIB += gdk_pixbuf-2.0 gio-2.0 glib-2.0 gmodule-2.0 +WANTLIB += gobject-2.0 harfbuzz iconv intl jpeg lzma m +WANTLIB += pango-1.0 pangocairo-1.0 pangoft2-1.0 pcre +WANTLIB += pixman-1 png pthread rsvg-2 tiff webp webpdemux +WANTLIB += xcb xcb-render xcb-shm xml2 z zstd MASTER_SITES = https://hpjansson.org/chafa/releases/ EXTRACT_SUFX = .tar.xz @@ -24,9 +26,15 @@ EXTRACT_SUFX = .tar.xz COMPILER = base-clang ports-gcc LIB_DEPENDS = devel/glib2 \ - graphics/ImageMagick + devel/harfbuzz \ + devel/pango \ + graphics/cairo \ + graphics/gdk-pixbuf2 \ + graphics/libwebp \ + x11/gnome/librsvg CONFIGURE_STYLE = gnu +CONFIGURE_ARGS += --without-imagemagick post-install: ${INSTALL_MAN} ${WRKSRC}/docs/chafa.1 ${PREFIX}/man/man1 Index: distinfo =================================================================== RCS file: /home/cvs/ports/graphics/chafa/distinfo,v retrieving revision 1.5 diff -u -p -r1.5 distinfo --- distinfo 22 Mar 2022 08:49:35 -0000 1.5 +++ distinfo 21 Jun 2022 09:55:28 -0000 @@ -1,2 +1,2 @@ -SHA256 (chafa-1.10.0.tar.xz) = iPS4sVQfmCMK8R1N4ujci4pMU329V9wvY/LgpI09aO4= -SIZE (chafa-1.10.0.tar.xz) = 511416 +SHA256 (chafa-1.12.1.tar.xz) = 8Iy82H9gS6IM+GmdwQc0lADyG4Jb4gSR6OCtqJlRlOo= +SIZE (chafa-1.12.1.tar.xz) = 653624
