On Wed, Jul 27, 2022 at 09:53 Brian Callahan <[email protected]> wrote:
> Hi Edd -- > > On 7/27/2022 9:05 AM, Edd Barrett wrote: > > Hi, > > > > Sometimes when you convert a video with handbrake, the audio track is > missing > > from the resulting file. > > > > This is detailed here: > > https://bugzilla.rpmfusion.org/show_bug.cgi?id=6006 > > > > And the fix is to apply this patch: > > > https://github.com/HandBrake/HandBrake/commit/f28289fb06ab461ea082b4be56d6d1504c0c31c2 > > > > Works for me. The below diff adds the patch to our port. OK? > > > > Yes, OK. I will try to get around to updating HandBrake this weekend. I see this patch has been committed. I look forward to testing as I had run into this issue a while ago, as well. Upon reviewing the aforementioned rpmfusion.org bug notes, I noticed some discussion regarding the HandBrake developers intending their bundled ffmpeg to be statically linked because it includes patches required for some functionality, see: <https://forum.handbrake.fr/viewtopic.php?p=196805#p196805> Looking at our HandBrake port, it appears to be using our ffmpeg port, not the bundled version. I don't want to suggest increasing port maintenance effort or package build times & sizes, so I wonder whether this is worth heeding or not. Thanks again, Morgan > -- Morgan --- http://makkintosshu.com/ http://centresteer.com/ http://seriesparts.com/ http://unna.org/
