On Tue, Aug 09 2022, Stuart Henderson <[email protected]> wrote:
> On 2022/08/09 02:10, Jeremie Courreges-Anglas wrote:
>> > Another approach with more explicit code would be to use a variable in
>> > the file names, that variable would hold either "rv64", "64" or "32"
>> > depending on the arch.
>>
>> That would give something like the diff below (tested on riscv64 and
>> amd64).
>
> fwiw: this one is a bit ugly, but it's easier to understand, I think
> I prefer it..
Yeah I figured that you folks would prefer the explicit version
(committed a few minutes ago).
>> +.if ${MACHINE_ARCH} == "riscv64"
>> +BINSUFFIX = rv64
>
> I understand why they might want 32/64, but why would they do such a
> thing for rv64?!
I think it isn't intentional, but only a side-effect from using
env["arch]" for different purposes in two different places.
There are other weird things in
https://github.com/godotengine/godot/commit/474d0f58f5f7c788f75798504173d653f4371b0a
#if __riscv_xlen == 8
8 should be 64
Some modules apparently only build on x86_64, so why not enable the
module on that arch, instead of disabling it on all other archs?
Modules like modules/theora and modules/regex are disabled on riscv64 for no
obvious reasons (missing/broken deps on the developer's machine?)
No idea why they're forcing -march=rv64gc either, it should be the
default on any generic purpose OS.
Omar, do you feel like reporting this upstream?
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
