On Tue, Aug 23 2022, aisha <[email protected]> wrote:
> On 8/23/2022 7:20 AM, Jeremie Courreges-Anglas wrote:
>> On Mon, Aug 22 2022, aisha <[email protected]> wrote:
>>> Hi,
>> Hi,
>>
>>> I've attached an update to net/knot and net/py-libknot to 3.2.0.
>>> A few library bumps, libknot has a symbol removed so updated its major
>>> version, libdnssec hasn't had any removals, I only see a few new ones,
>>> so I updated its minor. A second look at libdnssec would be useful.
>> libdnssec started to use new symbols from libc but doesn't export any
>> new symbols per se, so a minor bump isn't needed. I have tweaked that
>> before committing..
>>
>> One thing that I noticed in the configure output: there is now support
>> for DNS over QUIC using libngtcp2.
>>
>> +checking for libngtcp2 = 0.7.0 libngtcp2_crypto_gnutls... no
>> [...]
>> + DoQ support: no
>>
>> We don't have a port for ngtcp2 (https://github.com/ngtcp2/ngtcp2/) yet,
>> but I suspect we will and it would be good to prevent knot from picking
>> up that lib in bulk builds.
>>
>> ok for the diff below?
>
> I've been playing around with QUIC on other servers, so maybe I can port
> ngtcp2 over the weekend. In which case it might be better to add the
> ngtcp2 as a dependency for knot.
I have started working on a port yesterday evening, let me clean it up.
> Will try it out and get back with more info. So maybe we can hold off on
> disabling quic for now?
Since there is no libngtcp2 library in ports, it does not matter much
right now.
*But* if libngtcp2 was already in the ports tree, we should disable the
hidden dep right away, to avoid build failures (burden on bulk builders)
and missing deps (burden on users installing/upgrading knot).
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/net/knot/Makefile,v
>> retrieving revision 1.68
>> diff -u -p -r1.68 Makefile
>> --- Makefile 23 Aug 2022 11:14:30 -0000 1.68
>> +++ Makefile 23 Aug 2022 11:19:38 -0000
>> @@ -43,6 +43,8 @@ CONFIGURE_ARGS += --with-storage=${LOCAL
>> --with-libidn \
>> --disable-dnstap \
>> --disable-maxminddb
>> +# QUIC support uses ngtcp2
>> +CONFIGURE_ARGS += --disable-quic
>> CONFIGURE_ENV = ac_cv_path_PDFLATEX="false" \
>> ac_cv_path_SPHINXBUILD="false" \
>>
>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
