On 2022/11/24 08:11:48 -0800, "Heppler, J. Scott" <[email protected]> wrote:
> Yes, I don't port frequently enough.  *.diff with patch-Makefile_inc
> attached.
> 
> On Nov 24, 2022: 16:52, Peter Hessler wrote:
> >:? x11/jgmenu/patches/patch-Makefile_inc
> >
> >Did you forget to cvs add this file to include it in the diff?
> >
> >-peter

two nitpicks:

> +LIB_DEPENDS =   x11/gnome/librsvg

spaces; after the = there should be a tab (another line in the
makefile mixes spaces and tabs :/)

> diff -N x11/jgmenu/patches/patch-Makefile_inc
> --- /dev/null   1 Jan 1970 00:00:00 -0000
> +++ x11/jgmenu/patches/patch-Makefile_inc       24 Nov 2022 15:44:43 -0000
> @@ -0,0 +1,12 @@
> +Index: Makefile.inc
> +--- Makefile.inc.orig
> ++++ Makefile.inc
> +@@ -15,7 +15,7 @@ else
> + datarootdir= $(prefix)/share
> + endif
> +
> +-CFLAGS  += -g -Wall -Os -std=gnu99
> ++CFLAGS  += -Wall -Os -std=gnu89
                     ^^^^

-Os should go too.

With this fixed it's the diff OK for me.


There's still a python file packaged, but I don't see the point of
keeping MODULES=python.  it's a (quoting) "quick hack to give the
Unity launcher an invisible and short-lived override_redrect=False
window", so pretty useless here.  (and would need a rdep on py-gtk.)


Thanks!

Reply via email to