On 2022/11/27 08:43, Bjorn Ketelaars wrote:
> On Sat 26/11/2022 20:12, Stuart Henderson wrote:
> > do any devs have time to check these please?
>
> Builds for me. Suggestion: alphabetize RDEPS (see diff below). Probably
> nitpicking but i think in the past it was suggested to used use a space
> between 'VAR' and '=', e.g. 'FLAVOR = python3' instead of
> 'FLAVOR= python3'.
>
> OK bket@
Thanks - I started following the dependency ordsr from the declaration
(setup.cfg, setup.py, pyproject.toml etc) for my more recent py-* ports,
it doesn't matter that much for the shorter ones but I find it helpful
when checking if anything was added in an update.
For = both styles are pretty common, I normally just add spaces when it's
ambiguous.
>
> diff --git devel/py-jaraco-collections/Makefile
> devel/py-jaraco-collections/Makefile
> index b5cf682..7af91cb 100644
> --- devel/py-jaraco-collections/Makefile
> +++ devel/py-jaraco-collections/Makefile
> @@ -16,8 +16,8 @@ MODULES= lang/python
>
> MODPY_PI= Yes
> MODPY_PYBUILD= setuptools_scm
> -RUN_DEPENDS= textproc/py-jaraco-text${MODPY_FLAVOR} \
> - devel/py-jaraco-classes${MODPY_FLAVOR}
> +RUN_DEPENDS= devel/py-jaraco-classes${MODPY_FLAVOR} \
> + textproc/py-jaraco-text${MODPY_FLAVOR}
>
> FLAVORS= python3
> FLAVOR= python3
> diff --git textproc/py-jaraco-text/Makefile textproc/py-jaraco-text/Makefile
> index 3ea1abb..b4a264b 100644
> --- textproc/py-jaraco-text/Makefile
> +++ textproc/py-jaraco-text/Makefile
> @@ -16,10 +16,10 @@ MODULES= lang/python
>
> MODPY_PI= Yes
> MODPY_PYBUILD= setuptools_scm
> -RUN_DEPENDS= devel/py-jaraco-context${MODPY_FLAVOR} \
> +RUN_DEPENDS= devel/py-autocommand${MODPY_FLAVOR} \
> + devel/py-jaraco-context${MODPY_FLAVOR} \
> devel/py-jaraco-functools${MODPY_FLAVOR} \
> devel/py-more-itertools${MODPY_FLAVOR} \
> - devel/py-autocommand${MODPY_FLAVOR} \
> textproc/py-inflect${MODPY_FLAVOR}
>
> FLAVORS= python3
>
