On Sat, Dec 17, 2022 at 11:06:32AM +0100, Omar Polo wrote: > On 2022/12/17 10:41:26 +0100, Pascal Stumpf <pas...@stumpf.co> wrote: > > On Sat, 17 Dec 2022 10:18:15 +0100, Pascal Stumpf wrote: > > > A few tweaks: > > > > > > * set MAKE_FLAGS so that the build respects CFLAGS > > > * NO_TESTS = Yes > > > * add README and endless.rc to the port itself, reformat, turn on -s per > > > default (syslog logging) > > > * add dedicated _endlessh user > > > * install a default config file into examples and @sample it > > > > * correct Nm in endlessh.1 > > there's an extra patch-Makefile.orig in the tarball and > pkg/endlessh.rc is executable when it doesn't need to. > > ok for me with that fixed.
Thanks to Pascal and you for the tweaks. I have tested the latest revision; works as expected and the changes seem fine to me. I took the liberty of fixing the last problems Omar mentioned in the attached port. > > > in pkg/README I'd say to symlink /etc/rc.d/endlessh to endlessh6 > instead of copying it, less to worry when updating. > > If I'm reading it correctly, it can't directly bind to 22 because it > doesn't start as root, it' would be nice to include an excerpt of the > pf configuration to redirect the port 22 to 2222. > > I'd use a patch instead of perl -pi in post-install to tweak the > configuration, it's more verbose but it's also more resiliant to > upstream changes to the file. > > Including the diff for user.list in case it comes in handy to who > would like to test it. > > Index: user.list > =================================================================== > RCS file: /home/cvs/ports/infrastructure/db/user.list,v > retrieving revision 1.413 > diff -u -p -r1.413 user.list > --- user.list 14 Dec 2022 12:09:05 -0000 1.413 > +++ user.list 17 Dec 2022 09:50:27 -0000 > @@ -395,3 +395,4 @@ id user group port > 884 _iblock _iblock net/iblock > 885 _mycorrhiza _mycorrhiza www/mycorrhiza > 886 _eduvpn _eduvpn net/eduvpn > +887 _endlessh _endlessh net/endlessh >
endlessh.tgz
Description: Binary data
