On 2022/12/26 14:59, Lucas Raab wrote:
> On Mon, Dec 26, 2022 at 11:33:25AM +0000, Stuart Henderson wrote:
> > On 2022/12/24 15:53, Lucas Raab wrote:
> > > Hello,
> > >
> > > Here's an update for bokeh to the latest, but needs more eyes and tests.
> > > I've had it rolling around in my tree for a bit and works, but I'm not
> > > going to pretend I extensively use its capabilities.
> > >
> > > Attached to this are two new RDEPs, the latter of which should be
> > > applicable to a future matplotlib update:
> > > * geo/py-xyzservices
> > > * math/py-contourpy
> >
> > contourpy needs WANTLIB and COMPILER=base-clang ports-gcc, otherwise
> > ok to import those.
> >
> Ah! Thanks for the reminder
>
> > > Tests are disabled as the pypi-hosted dist hasn't provided tests.
> > > Setting GH_ does obviously get the tests, but then the python build
> > > process wants to rebuild the css files and wants node to do so. There
> > > are also many, many more TDEPs that would need to imported.
> >
> > Small nit below otherwise bokeh looks good to me too (I can't do
> > extensive testing either, but I don't think that's really needed
> > anyway, as long as the basics work if there are problems they're
> > unlikely to be OpenBSD-specific).
> >
> > > RUN_DEPENDS= devel/py-dateutil${MODPY_FLAVOR} \
> >
> > Looks like this can be dropped, I don't see it used any more
>
> Heh, I saw the removal in the release notes, but assumed it was a
> used-if-available vs outright removal. I should have looked closer...
>
> >
> > > devel/py-typing-extensions${MODPY_FLAVOR}>=3.10.0.0 \
> >
> > (This is no longer a listed dependency but is still imported in some
> > cases so makes sense to keep it listed. typing.extensions is part
> > of core Python and as of 3.10 many ports can use that instead of
> > typing_extensions which is an external module).
> >
>
> Sounds good. Updated diff attached also fixing the order of numpy and
> pandas in RDEPs.
OK. fwiw I would add a "not in pypi distfile" comment next to NO_TEST
(and maybe drop the "several TDEPs don't exist" in this case; when I
tried running tests in older versions, we didn't have everything listed,
but a decent number of tests ran anyway)
