Hello, On 2023/01/12 23:18:19 +0100, Mattia Chiozzi <[email protected]> wrote: > Hi, > I made a port for xnotify (https://github.com/phillbush/xnotify). > No issues to report.
There are a couple of nitpicks, but otherwise the port it's fine. It's also an interesting small utility! Do you have a port for tiramisu too? I'm tempted to see how it works compared to, say, dunst in practice. Anyway, regarding the port: - there is a bit of redundancy. GH_* automatically sets DISTNAME and HOMEPAGE, so no need to specify them. - REVISION is not set for new ports (or when you bump the verision.) It starts empty. Then, if the port needs to be tweaked without bumping the version is set to 0, and then (eventually) incremented. - dependency outside of the base system needs to be listed in LIB_DEPENDS: graphics/imlib2 in this case. - WANTLIB wasn't defined. it list the actual libraries needed by the port. `make port-lib-depends-check' is your friend for building the list and checking it again on updates. (it also helps with spotting missing LIB_DEPENDS entries.) - the custom do-install target can be avoided by setting FAKE_FLAGS so that the manpage is installed in the correct place. - last thing, the port was build with -O0 and didn't picked up our CFLAGS. Ports needs to build using the CFLAGS provided by the port infrastructure (see `make show=CFLAGS' and compare with the output of the build.) Fortunately it's easy to fix too, just add CFLAGS to MAKE_FLAGS. - last thing, we generally use tabs to indent, not spaces I'm attaching an updated tarball with these points addressed that's ok op@ to import. Thanks! Omar Polo
xnotify.tar.gz
Description: GNU Zip compressed data
