Stuart Henderson <s...@spacehopper.org> wrote:

> On 2023/01/21 17:36, Volker Schlecht wrote:
> > 
> > 
> > On 1/19/23 22:56, Theo Buehler wrote:
> > 
> > > The trick to apply such patches is to add .diff to the
> > > github link.
> 
> Or .patch, then you get a nice header to paste into the top of
> the patch file too.
> 
> > Neat! I just noted that down ... ;-)
> > 
> > Here's a patch that builds node without USE_NOEXECONLY and
> > without those warnings, producing a working binary on amd64 ...
> > I'm starting builds on i386 and arm64, but since I'm not sure I
> > understand the problem to its full extent, it may - figuratively
> > - need some adult supervision.
> 
> i386 doesn't have execute-only anyway (though as it's touching a file
> which looks like it may affect i386 too, testing that it doesn't break
> is helpful).

moving tables from text into rodata on other architectures will not
create any harm, except there maybe PIC considerations, so some changes
for that may need to be written and tested.

Reply via email to