On 2023/01/24 15:36:22 +0100, Laurent Cheylus <[email protected]> wrote:
> Hi,
>
> proposal to import devel/gopls for gopls version 0.11.0
>
> gopls is the official Go language server developed by the Go team
> https://pkg.go.dev/golang.org/x/tools/gopls
>
> Changelog for version 0.11.0
> https://github.com/golang/tools/releases/tag/gopls%2Fv0.11.0
>
> Build and tests OK on amd64 using Neovim editor + configuration with
> nvim-lsp plugin.
>
> Comments welcome and please commit if OK.
gopls is already included in go-tools, so it would conflict.
% pkglocate bin/gopls
go-tools-1.12.20190226p2:devel/go-tools:/usr/local/bin/gopls
However the latter hasn't receved much love recently. (I for one
forgot its existance, i have a locally installed gopls in ~/go/bin.)
I would agree with splitting gopls as standalone port. It would make
go-tools easier to update and even upstream seems to consider gopls
separate from the other go-tools (gopls has its own tags in the repo.)
Otherwise your port looks ok to me, just consider this semplification
for post-install:
--- Makefile.orig Tue Jan 24 16:43:28 2023
+++ Makefile Tue Jan 24 16:43:50 2023
@@ -21,13 +21,9 @@
DOCDIR = ${PREFIX}/share/doc/gopls
post-install:
- ${INSTALL_DATA_DIR} ${DOCDIR}
+ ${INSTALL_DATA_DIR} ${DOCDIR}/doc/design
${INSTALL_DATA} ${WRKSRC}/README.md ${DOCDIR}
-
- ${INSTALL_DATA_DIR} ${DOCDIR}/doc
${INSTALL_DATA} ${WRKSRC}/doc/*.md ${DOCDIR}/doc
-
- ${INSTALL_DATA_DIR} ${DOCDIR}/doc/design
${INSTALL_DATA} ${WRKSRC}/doc/design/*.md ${DOCDIR}/doc/design
.include "modules.inc"
it would also need a @conflict marker in pkg/PLIST... but let me take
a look at updating go-tools first.
Thanks,
Omar Polo
