On Fri, Jan 27, 2023 at 05:13:53PM +0100, Janne Johansson wrote: > It fails building one of the autogenerated source which forces tail > call optimization on clang13 (actually in llvm somewhere, "musttail" > feature) which is only available for certain arches, and causes a hard > failure on mips64 (and probably other arches aswell).
Thank you. Committed with __mips64__ since I was told this is preferred. It would be super nice if you could send a PR upstream, so we don't have to carry this patch forever. > One can disable it for more arches I guess, but I have only tested it > on my octeon, built the package and then mosh (which depends on it) > and tried mosh as a client which worked. mosh is a good test. Another good test is to run regress for py-protobuf. > mosh's "make test" fails in one test about > 80columns-emulation-something, didn't feel all relevant to protobufs, > but I don't know for certain about that. I haven't tried with the most recent mosh update, but that failing test rings a bell and doesn't seem likely to be related.
