Le Mon, Feb 06, 2023 at 09:41:23AM +0000, Klemens Nanni a écrit : > tb pointed out the build failure. > devel/abseil-cpp appears to be a build dependency.
c64:/usr/obj/ports/mapserver-8.0.0/mapserver-8.0.0/ $grep -ri abseil . ./third-party/nlohmann/json.hpp:// The following code is taken from https://github.com/abseil/abseil-cpp/blob/10cb35e459f5ecca5b2ff107635da0bfa41011b4/absl/utility/utility.h ./third-party/nlohmann/json.hpp:// which is part of Google Abseil (https://github.com/abseil/abseil-cpp), licensed under the Apache License 2.0. ./third-party/nlohmann/json.hpp://// START OF CODE FROM GOOGLE ABSEIL ./third-party/nlohmann/json.hpp://// END OF CODE FROM GOOGLE ABSEIL technically, abseil is *not* a bdep for mapserver, but apparently this could also be fallout of the nlohmann-json update ? mapserver bundles 3.10.5. > Set cmake's C++ standard to 14 (currently 11 is used) as the newest > abseil-cpp LTS requires 14 or later. that code is within #ifdef JSON_HAS_CPP_14 so maybe that part is right, but definitely not adding abseil-cpp as a bdep. > bumped with `portbump -r', PLIST changes are from `update-plist'. > Build-tested only. update-plist can be stupid sometimes. Do you really thing adding +lib/php-${MODPHP_VERSION}/ to PLIST-utils make sense ? > Feedback? Objection? OK? Definitely not ok :)
