On 2023/02/11 10:48:00 +0000, Yifei Zhan <[email protected]> wrote:
> 
> (manual bump of [1], used it today on -current, works fine as usual)
> 
> Attached is a port for multimedia/karlyriceditor:
> 
> Karaoke Lyrics Editor is a program lets you edit and synchronize lyrics with
> karaoke songs in various formats. Currently supported formats include LRC,
> LRCv2 (supported by XBMC) and Ultrastar (without pitch).
> 
> Tested on OpenBSD-current/{amd64,arm64}, I've used it to edit lyrics for a 
> few 
> months now, no problem so far.
> 
> port-lib-depends-check and portcheck are happy.
> 
> any comments?

plist needs to be re-generated, share/applications is owned by
desktop-file-utils:

        % diff -u pkg/PLIST{.orig,}
        --- pkg/PLIST.orig      Mon Jan  9 06:18:15 2023
        +++ pkg/PLIST   Fri Feb 17 10:58:04 2023
        @@ -1,5 +1,4 @@
         @bin bin/karlyriceditor
        -share/applications/
         share/applications/karlyriceditor.desktop
         share/pixmaps/
         share/pixmaps/karlyriceditor.png

I'd avoid the comments in do-install, it's juite clear what you're
doing, but it's just a matter of personal style.

not really runtested, I just opened the GUI and clicked around, but
seems to work and ports looks fine to me.  With plist fixed, ok op@
for import if someone wants to :)

Reply via email to