On Sat, Mar 11, 2023 at 12:55:39PM +0000, Klemens Nanni wrote:
> 10.03.2023 20:47, Klemens Nanni ??????????:
> > +++ pkg/PLIST-main 10 Mar 2023 14:45:13 -0000
> > @@ -22,81 +22,84 @@
> > @man man/man1/transmission-remote.1
> > @man man/man1/transmission-show.1
> > @comment share/applications/
>
> (This @comment can probably go well and then get cleaned up from
> update-plist, now that I see it...)
>
> > +share/doc/transmission/
> > +share/doc/transmission/AUTHORS
> > +share/doc/transmission/COPYING
> > +share/doc/transmission/README.md
> > +share/doc/transmission/news/
> > +share/doc/transmission/news/news-2.42-and-older.md
> [lots of news files]
> > +share/doc/transmission/news/news-4.0.1.md
> > +share/doc/transmission/rpc-spec.md
> > +share/doc/transmission/send-email-when-torrent-done.sh
>
> These come from default INSTALL_DOC, either default =ON should put the
> script into the examples dir and account for its nail(1) usage, imho, or
> =OFF should be used to skip all those files. Or just zap news/?
>
>
> Enabling tests could be useful, they use a bundled gtest, though.
> Perhaps upstream could change that to allow system gtest?
>
>
> Regardless of the update, is transmission.rc's daemon_reload=NO still
> accurate? In 4.0.1 ${WRKSRC}/daemon/daemon.cc I see
>
> 750 /* If we got a SIGHUP during startup, process that now. */
> 751 if (seen_hup_)
> 752 {
> 753 reconfigure();
> 754 }
>
> which looks like the daemon is reconfiguring on HUP, i.e. reloading.
Thank you, Klemens, for all your help. I will review.
