Hi,

Thanks for the comments.

The "lib" in the path is for a user-local library path, which was
the original spec.  I have no idea if any/most Klong users
rely on this.  No problem to remove.

Re Backspace as Delete, well, it is a delete, as in the Klong
TUI the Ctrl-B character is backspace (that is, does not
delete anything but moves the cursor.)  On my keyboard
"Backspace" button my fingers identify as "delete".  So I
kept my fingers happy.

I thought about arc4random_uniform but decided this way to
minimize API change.

Thanks for reviewing.

J


On 2023-04-05 09:34, Omar Polo wrote:
Hello,

On 2023/03/31 08:59:55 -0600, [email protected] wrote:
Here is Klong, a very terse array language.

Tested on amd64, but probably good everywhere.

"Klong is an expression-based language that is inspired by K,
which is in turn inspired by APL. A Klong program is basically
a set of functions that manipulate list or array structures.
You might also think of Klong as a glorified calculator with a
massive set of functions for transforming arrays in various
ways."


J

First time I'm playing with an array language, but the klong-intro.txt
file seems a nice introduction.

Now, regarding the port, you can avoid patching the Makefile by using
MAKE_FLAGS:

        MAKE_FLAGS += CFLAGS="${CFLAGS}"

Regarding the other patch, some nits:

 - I'm not a klong user but I'd remove "lib" from DFLPATH and just
   leave ".:/usr/local/lib/klong".  I guess 'lib' is there so folks
   can use it when building and running from the tarball.

 - "accept Backspace as delete" is misleading, since you're making the
   delete character to behave like a backspace :P

(you could have written '?' + '@' instead of 127 to match the style :P)

 - since you're patching sys_randnum anyway I would have used
   arc4random_uniform.  I haven't thought if it's correct.

otherwise it looks fine to me and it seems a fun language.  I'm
attaching an updated tarball that address above points that's ok op@
to import.


Thanks!

P.S.: I don't know what the current stace regarding hardcoded paths
      is.  Is it fine to hardcode /usr/local/lib/klong or we should do
      the SUBST_CMD dance?

Reply via email to