On 2023/04/12 18:10:48 +0200, Omar Polo <[email protected]> wrote:
> On 2023/04/06 22:39:03 +0100, Edd Barrett <[email protected]> wrote:
> >  - portcheck gave me a warning I didn't fully understand:
> > 
> >    "the following libraries in WANTLIB look like masked by RUN_DEPENDS: 
> > rsvg-2 xml2"
> > 
> >    Besides the warning needing a rewording, I've added textproc/libxml and
> >    x11/gnome/librsvg as RUN_DEPENDS to silence it, but I don't understand 
> > why
> >    it's needed. If they are valid in WANTLIB (`make port-lib-depends-check` 
> > is
> >    fine with it) then something must have already pulled them in...
> 
> No idea, but for me it's happy without libxml and librsvg explicity
> listed in LIB_DEPENDS (they should be already pulled in by x11/gtk+3.)

Ah, I was wrong.  I assumed that error comes from `make
port-lib-depends-check' (which is fine for me), while instead is a
portcheck check.  I haven't looked into it but I think it's a
portcheck error and not a mistake in the port since those libraries
are correctly reachable via LIB_DEPENDS.

> [...]

I noticed that the port doesn't install the desktop files.
CMakeLists.txt installs them only for Linux :/

I'm attaching a tarball with the previous things addressed and a patch
to install the desktop files too, that's ok op@ if you want to import
it.

Having tested it on a touchscreen laptop can confirm it works fine :-)

Attachment: xournalpp.tar.gz
Description: GNU Zip compressed data

Reply via email to