Nam Nguyen writes:
> - workaround in Makefile patch from [1] for vasprintf bug in openbsd
>   headers when POSIX_C_SOURCE=200809L is defined. This was discussed by
>   bentley@ in [1] and rsadowski@ in [2]. I propose having this as a
>   temporary workaround until openbsd's llvm headers can be fixed with a
>   more optimal solution[3].
> [1] https://github.com/gbdev/rgbds/issues/1111
> [2] https://marc.info/?l=openbsd-tech&m=161833545600505&w=2
> [3] https://marc.info/?l=openbsd-bugs&m=157758838031146&w=2

I did look at this recently. However, that patch is not actually
relevant to this bug (vasprintf visibility issues), but to another
bug (locale_t visibility issues).

> Testing:
> https://gbdev.io/gb-asm-tutorial/part1/hello_world.html
>
> I followed this hello world tutorial and loaded the rom in
> emulators/sameboy. It successfully printed.

sameboy actually has a build dependency on rgbds. Can you test that it
still builds?

Reply via email to