On 2023/04/13 21:56:43 +0200, Florian Viehweger <[email protected]> 
wrote:
> Hi,
> 
> this updates openttd to 13.1, changes are listed here[1].
> 
> I've played a bit on amd64 and found no issues.
> 
> Comments?

builds and works fine for me.  `make port-lib-depends-check' complains
about unneeded WANTLIBs but I guess that's due to SDL2 being
statically linked:

        % mpldc

        openttd-13.1(games/openttd):
        Extra:  X11.18 Xcursor.5 Xext.13 Xfixes.6 Xi.12 Xrandr.7 Xss.6
        Extra:  samplerate.3 sndio.7 usbhid.7

I've tried again to see why it gets linked statically, but got
headaches reading CMakeLists.txt.  I tried to set up a simple
reproduction project but FindSDL2.cmake seems to dynamically link by
default.  No idea.

So, I guess it's ok to commit the diff as-is until someone figures
this out.  Dropping those deps from WANTLIB should make it worse.
Will do in a couple of days provided nobody objects (but hoping
someone will understand what's going on ;-)

P.S.: if grep doesn't lie -and assuming I know how to grep- there are
      no dlopen() calls.

> Index: Makefile
> ===================================================================
> RCS file: /daten/openbsdmirror/cvs/mirror/ports/games/openttd/Makefile,v
> retrieving revision 1.83
> diff -u -p -u -p -r1.83 Makefile
> --- Makefile  28 Feb 2023 14:16:34 -0000      1.83
> +++ Makefile  13 Apr 2023 16:16:37 -0000
> @@ -1,9 +1,8 @@
>  COMMENT=     open source clone of the game Transport Tycoon Deluxe
>  
> -V =          13.0
> +V =          13.1
>  DISTNAME =   openttd-$V-source
>  PKGNAME =    openttd-$V
> -REVISION =   1
>  
>  CATEGORIES=  games
>  
> Index: distinfo
> ===================================================================
> RCS file: /daten/openbsdmirror/cvs/mirror/ports/games/openttd/distinfo,v
> retrieving revision 1.43
> diff -u -p -u -p -r1.43 distinfo
> --- distinfo  23 Feb 2023 19:46:44 -0000      1.43
> +++ distinfo  13 Apr 2023 16:16:37 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (openttd/openttd-13.0-source.tar.xz) = 
> M5344OCCcIfIOv54+O/GpzsKPYqVCgtTE3zm6KrXq2c=
> -SIZE (openttd/openttd-13.0-source.tar.xz) = 7422316
> +SHA256 (openttd/openttd-13.1-source.tar.xz) = 
> Xt8i03A1I4KF72cql9WeZCgL66sj5YR4CDTM1r4KWLs=
> +SIZE (openttd/openttd-13.1-source.tar.xz) = 7407360


Reply via email to