On 2023/04/30 11:41, Thomas Frohwein wrote: > > > > naddy uncovered a build failure with emulators/flycast. I will have > > details in the flycast email, but the proposed solution is to build > > shared libraries in graphics/glslang so that flycast can use libSPIRV.so > > and libglslang.so.0.0. > > > > >>> +@so lib/libHLSL.so > > >>> +@so lib/libSPIRV.so > > >>> +@so lib/libSPVRemapper.so > > >>> +@so lib/libglslang-default-resource-limits.so > > >>> +@lib lib/libglslang.so.${LIBglslang_VERSION} > > > > Having shared libraries without semantic versioning might be fine? > > Upstream seems to only want to add semantic versioning to the main > > library, libglslang.so.0.0. > > We have other ports that have shared libraries without version suffix; > games/lwjgl comes to mind for me. There are probably others, too.
They aren't usually in /usr/local/lib though. If they're linked against by other ports, they should have versions. If they're just modules which are dlopen()d by the port then usually no versions. > > +REVISION = 1 > > + > > +SHARED_LIBS += glslang 0.0 # 12.0 > > Does it add version numbers if you add the other libs to SHARED_LIBS and rebuild?