On Mon, May 08, 2023 at 02:59:25AM +0200, Antoine Jacoutot wrote:
> Two PKGSPEC ? 
> 
> —
> Antoine

Ah oops, I forgot about the second one (which will obviously take precedence)
(And I didn't check the makefile)

Yeah, it's just the patch itself that warrants any attention


> > On 7 May 2023, at 20:30, Marc Espie <[email protected]> wrote:
> > 
> > The gitlab issue says it all.
> > 
> > I've just checked that with this, heavily italicized fonts (like Palooka 
> > Italic)
> > do render correctly even when right-justified.
> > 
> > Okay ?
> > 
> > (it appears that gimp 2.99.14 as the exact same issue, but I haven't checked
> > it yet)
> > 
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/graphics/gimp/stable/Makefile,v
> > retrieving revision 1.161
> > diff -u -p -r1.161 Makefile
> > --- Makefile    24 Apr 2023 11:40:44 -0000    1.161
> > +++ Makefile    7 May 2023 18:26:39 -0000
> > @@ -2,7 +2,7 @@ COMMENT=    GNU Image Manipulation Program
> > 
> > DISTNAME =    gimp-2.10.34
> > PKGSPEC =    gimp->=2,<2.99
> > -REVISION =    1
> > +REVISION =    2
> > 
> > .for i in gimp gimpbase gimpcolor gimpconfig gimpmath gimpmodule \
> >    gimpthumb gimpui gimpwidgets
> > @@ -18,6 +18,7 @@ MASTER_SITES=    https://download.gimp.org/
> > HOMEPAGE=    https://www.gimp.org/
> > 
> > EXTRACT_SUFX=    .tar.bz2
> > +PKGSPEC =    gimp-<3
> > 
> > # GPLv3+
> > PERMIT_PACKAGE=    Yes
> > Index: patches/patch-app_text_gimptextlayout_c
> > ===================================================================
> > RCS file: patches/patch-app_text_gimptextlayout_c
> > diff -N patches/patch-app_text_gimptextlayout_c
> > --- /dev/null    1 Jan 1970 00:00:00 -0000
> > +++ patches/patch-app_text_gimptextlayout_c    7 May 2023 18:26:39 -0000
> > @@ -0,0 +1,13 @@
> > +See https://gitlab.gnome.org/GNOME/gimp/-/issues/325
> > +Index: app/text/gimptextlayout.c
> > +--- app/text/gimptextlayout.c.orig
> > ++++ app/text/gimptextlayout.c
> > +@@ -655,7 +655,7 @@ gimp_text_layout_position (GimpTextLayout *layout)
> > +       GimpTextDirection base_dir = layout->text->base_dir;
> > +       gint              width;
> > + 
> > +-      pango_layout_get_pixel_size (layout->layout, &width, NULL);
> > ++      width = layout->extents.width;
> > + 
> > +       if ((base_dir == GIMP_TEXT_DIRECTION_LTR && align == 
> > PANGO_ALIGN_RIGHT) ||
> > +           (base_dir == GIMP_TEXT_DIRECTION_RTL && align == 
> > PANGO_ALIGN_LEFT) ||
> > 
> 
> 

Reply via email to