On Sun, May 14, 2023 at 10:27:37AM +0300, Anton Konyahin wrote: > One more ping for games/brogue
Nice one, port looks good, builds and runs here. Only nit would be maybe adding NO_TEST=Yes as there are no regression tests. Otherwise ok thfr@ > On 07/05, Anton Konyahin wrote: > > On 02/05, Omar Polo wrote: > > > On 2023/05/02 22:21:59 +0300, Anton Konyahin <[email protected]> wrote: > > > > On 02/05, Omar Polo wrote: > > > > > I'm recluntant to patch like this an upstream software since while > > > > > for now it could work fine, these kind of changes are very likely to > > > > > break in future updates. > > > > > > > > At first, I tried to fix all warnings in brogue, but there is a > > > > hundreds of strcpy and other sprintf, so I gave up. I am glad to see > > > > fewer patches in port, really. > > > > > > for fix like strcpy/sprintf etc, especially when there are a lot to > > > fix, working with upstream is a better option. You can try to start > > > fixing a few of them, sending a patch and see how it goes. Time > > > allowing, you can follow-up with more fixes. > > > > > > > I tested your tarball and everything works like a charm. Should I do > > > > something else for this port? > > > > > > The policy is two ok in order to import something new. My tarball was > > > obviously ok op@ to import, so we just need to wait for another > > > developer to import with my ok :) > > > > > > I've played it for a bit, it's fun and the graphics are nice. I'd > > > like to see it being imported. > > > > > > Thanks! > > > > > > > Ping. Can somebody else look at this port, please? > >
