On 2023-05-16 09:30, Theo Buehler wrote: > On Mon, May 15, 2023 at 04:47:31PM -0600, Ashlen wrote: > > I tested the update briefly and it works. Noticed some errors in `make > > test` about rand(), strcat(), and sprintf(), but I'm unsure what to do > > about those. Adding boost_atomic-mt to WANTLIB was necessary to pass > > port-lib-depends-check. > > > > Feedback? I hope I didn't miss anything obvious. > > Your patch didn't apply cleanly because of tabs vs spaces in this line: > > > -GH_TAGNAME = 2.46.1 > > +GH_TAGNAME = 2.47.0 > > Not sure how that happened. Avoid copy-pasting diffs. For example tmux > likes to convert tabs into spaces.
Shoot, I always forget it does that. That's exactly the mistake I made, too. Sorry about that, it's a bad habit. Next time I'll be sure to avoid copy-pasting and to test the patch itself before sending. Thank you both for all the feedback. :) Am still pretty new to ports stuff, but I'll do my best to learn from all of the suggestions I get.
