On 2023/05/18 19:04, Omar Polo wrote:
On 2023/05/18 16:51:01 +0200, Laurent Cheylus <f...@free.fr> wrote:
an update for devel/goreleaser for the latest version 1.18.2.

- update Makefile and modules.inc for version 1.18.2
- add MODGO_LDFLAGS variables for date and builtBy (displayed via
'goreleaser -v')

Build and tests OK on current/amd64 with Go 1.20.4.

Comments welcome and please commit if OK.

-MODGO_LDFLAGS =        -X main.version=${MODGO_VERSION:S/v//}
+MODGO_LDFLAGS +=       -X main.version=${MODGO_VERSION:S/v//}
+MODGO_LDFLAGS +=       -X main.date=$$(date +"%Y-%m-%d")

please don't

+MODGO_LDFLAGS +=       -X main.builtBy=$$(id -u -n)

likewise.

it is really important to show that it was build by _pbuild?  I doubt.

You're right, these infos are useless => remove MODGO_LDFLAGS for date and user (buildBy) in Makefile.

(this makes me think you're not building ports with PORTS_PRIVSEP=Yes,
which I recommend doing; see bsd.port.mk(5).)

I'm using PORTS_PRIVSEP to build ports according to bsd.port.mk (+ solene@ blog post https://dataswamp.org/~solene/2020-01-11-privsep.html)

will take a better look later.

Thanks for your tests and comments, Laurent

Reply via email to