On 2023/05/28 21:53:50 +0100, Alexander Arkhipov <a...@manpager.net> wrote: > Hello, > > xclickroot is an X program for running commands on clicking the root > window. It seems to build very cleanly, and so far I've encountered no > problems with it. The port's tarball is attached to this letter. > > Any comments? Thanks. > > https://github.com/phillbush/xclickroot
looks fine, thanks!
Only one nit: it doesn't respect CFLAGS from the ports infrastructure.
When passing CFLAGS we need to add -I too because it doesn't pass
CPPFLAGS to the ${CC} invocation.
Attaching a diff against your makefile and an updated tarball that's
OK op@ to import.
Cheers,
Omar Polo
--- Makefile.orig Mon May 29 07:51:02 2023
+++ Makefile Mon May 29 07:52:45 2023
@@ -13,7 +13,8 @@
WANTLIB += X11 c
-MAKE_FLAGS = MANPREFIX=${TRUEPREFIX}/man
+MAKE_FLAGS = CFLAGS="${CFLAGS} -I${X11BASE}/include" \
+ MANPREFIX=${TRUEPREFIX}/man
NO_TEST = Yes
xclickroot.tar.gz
Description: GNU Zip compressed data
