On 2023/06/10 21:13, lux wrote:
> Hi ports@,
> 
> htmlq is a like `jq' tool, but for HTML. Uses CSS selectors to extract
> bits of content from HTML files.
> 
> Github: https://github.com/mgdm/htmlq
> 
> I'm make a port, and test on AMD64 7.3, works fine for me:
> 
> $ uname -a 
> OpenBSD openbsd 7.3 GENERIC.MP#1125 amd6
> $ curl --silent www.openbsd.org | htmlq title
> <title>OpenBSD</title>
> $ curl --silent www.openbsd.org | htmlq --text title
> OpenBSD
> $ curl --silent 'https://www.openbsd.org/faq/faq4.html#Download' |
> htmlq --attribute href a | grep '\.iso'
> https://cdn.openbsd.org/pub/OpenBSD/7.3/alpha/install73.iso
> ...
> 
> Known issues at compile time, cargo will generate a warning when it is
> compiled:
> 
> > warning: the following packages contain code that will be rejected by
> a future version of Rust: html5ever v0.25.1
> 
> This warn is about trailing semicolons when using Rust macros
> (https://github.com/rust-lang/rust/issues/79813) and can be ignored for
> now.
> 
> OK to import? Thank you.

- Should use crates.inc not modules.inc

- You have this...

# for riscv64 and powerpc65, please keep: libc >= 0.2.113
MODCARGO_CRATES_UPDATE =        libc

but you didn't use an updated libc version in the MKDCARGO_CRATES lines

(also typo, should be powerpc64)

- there's a lot of repetition in pkg_info because you've included things
in DESCR which are already printed - the contents of COMMENT, and the
website URL which is added automatically from HOMEPAGE:

$ pkg_info htmlq
Information for inst:htmlq-0.4.0

Comment:
like jq, but for HTML

Description:
Like jq, but for HTML. Uses CSS selectors to extract bits of content
from HTML files.

For information about how to use this, see https://github.com/mgdm/htmlq.

Maintainer: Xi Lu <[email protected]>

WWW: https://github.com/mgdm/htmlq

- little request, I'd find it easier if you sent tar.gz rather than zip,
vim's archive viewer is a little nicer for tar.gz (can show all files
in a directory in one screen, rather than having to open them one by
one, which makes it slightly faster to read through when reviewing)

Reply via email to