On Tue, Aug 01, 2023 at 07:17:47PM +0000, Megerman, Joshua wrote:
> The current version of rdiff-backup depends on the pkg_resources python
> module (part of py3-setuptools) to determine the installed version, and if
> that isn't found it defaults to the string 'DEV" rather than the actual code
> version. Installing the rdiff-backup-2.0.5 package does not automatically
> install the py3-setuptools package, which then causes interoperability issues
> between system that have the pkg_resources module and those that don't,
> because the version strings don't match. I'm not well-versed enough with
> Python or the Ports to know exactly how to change the port to do the
> requirement, but I suspect it's just adding py3-setuptools to the WANTLIB
> line in the Makefile. I have confirmed that simply installing the
> py3-setuptools package on a system with rdiff-backup already installed
> changes the reported version string from 'DEV' to '2.0.5', so it's easy
> enough for me to fix by hand in situ, but fixing the package would be better
> for those who don't know.
WANTLIB contains libraries against which a port links.
setuptools is a runtime dependency as listed in the port's setup.py file.
In any case, always best to Cc a package's maintainer.
This should do the trick.
Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/rdiff-backup/Makefile,v
retrieving revision 1.25
diff -u -p -r1.25 Makefile
--- Makefile 5 Dec 2022 16:00:56 -0000 1.25
+++ Makefile 1 Aug 2023 21:24:18 -0000
@@ -2,6 +2,7 @@ COMMENT = incremental backup
MODPY_EGG_VERSION = 2.0.5
DISTNAME = rdiff-backup-${MODPY_EGG_VERSION}
+REVISION = 0
CATEGORIES = sysutils
@@ -20,6 +21,8 @@ MODULES = lang/python
MODPY_PI = Yes
MODPY_PYBUILD = setuptools_scm
CFLAGS += -I${LOCALBASE}/include
+
+RUN_DEPENDS = devel/py-setuptools${MODPY_FLAVOR}
# tests are present but are intended to run via Tox in a Docker container
NO_TEST = Yes
