On 8/8/23 11:34, Paco Esteban wrote:
> On Tue, 08 Aug 2023, Sebastien Marie wrote:
>
>> On Tue, Aug 08, 2023 at 04:01:17PM +0200, Paco Esteban wrote:
>>> Find attached the updated version that removes the wrapper script and
>>> makes use of login classes.
>>>
>> one question:
>>
>> in pkg/README, you have the example
>> # rcctl set shiori flags -a 0.0.0.0 -p 1234
>>
>> and in pkg/shiori.rc, the default daemon_flags value is "serve -a localhost"
>>
>> if I properly understand thecommand-line, 'serve' is a command which is
>> required
>> to be passed for the service.
>>
>> if you don't want to have to pass it systematically (rcctl set shiori flags
>> serve -a 0.0.0.0 -p 1234),
>> maybe the following will work:
>>
>> pkg/shiori.rc
>> -daemon="${TRUEPREFIX}/bin/shiori"
>> +daemon="${TRUEPREFIX}/bin/shiori serve"
>> daemon_user="_shiori"
>> -daemon_flags="serve -a localhost"
>> +daemon_flags="-a localhost"
>>
>> thanks.
> I thought about it at some point and got distracted by the wrapper/login
> class thing.
>
> Here's the port with those changes.
Don't need the line
ONLY_FOR_ARCHS = ${GO_ARCHS}
That's already set by the go.port.mk
Also if you use LOCALSTATEDIR instead of VARBASE in the README then you
don't need to add it to SUBSTVARS, but I don't particularly care about
that one.
Other than that OK aisha@
> Thank you Sebastien.
>
