On 2023/09/03 10:32:00 +0200, Omar Polo <[email protected]> wrote:
> I considered making the variable more like SUBST_VARS (i.e. just a
> list of variable names) but then we loose the ability to express -F
> which can be handy. Or maybe I'm overthinking it.
just as I sent the email I noticed that my cargo.port.mk diff wasn't
right. Turns out, -F is really needed :-)
with the fixed carg.port.mk diff:
% pwd
/usr/ports/devel/difftastic
% make port-lib-depends-check
[...]
WANTLIB += ${COMPILER_LIBCXX} ${MODCARGO_WANTLIB} m
*** Error 1 in target 'port-lib-depends-check' (ignored)
Index: cargo.port.mk
===================================================================
RCS file: /home/cvs/ports/devel/cargo/cargo.port.mk,v
retrieving revision 1.37
diff -u -p -r1.37 cargo.port.mk
--- cargo.port.mk 26 Jul 2023 07:56:18 -0000 1.37
+++ cargo.port.mk 3 Sep 2023 08:41:42 -0000
@@ -36,6 +36,9 @@ MODCARGO_WANTLIB += c++abi
MODCARGO_WANTLIB +=
.endif
+CHECK_LIB_DEPENDS_ARGS += -S MODCARGO_WANTLIB="${MODCARGO_WANTLIB}"
+CHECK_LIB_DEPENDS_ARGS += -F pthread -F c++abi
+
# Define MASTER_SITES_CRATESIO for crates.io
MASTER_SITES_CRATESIO = https://crates.io/api/v1/crates/
